Issue 164653
Summary [libc] Incorrect architecture guarding macros in x86 sigsetjmp.cpp
Labels libc
Assignees
Reporter bojle
    [This](https://github.com/llvm/llvm-project/blob/main/libc/src/setjmp/x86_64/sigsetjmp.cpp) has the following structure of code inclusion guards:

```
#if __i386__
// i386 implementation
#endif 
// x86-64 implementation
```
Whereas it should really be:
```
#if __i386__
// i386 implementation
#else 
// x86-64 implementation
#endif 
```
[setjmp.cpp](https://github.com/llvm/llvm-project/blob/main/libc/src/setjmp/x86_64/setjmp.cpp) does this correctly. 

Is this intended? Or is it an issue? I can make a quick fix if this is a bug.

@SchrodingerZhu @michaelrj-google 

_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to