| Issue |
179125
|
| Summary |
Mark LowerTypeTests pass as isRequired
|
| Labels |
good first issue,
llvm:SelectionDAG
|
| Assignees |
|
| Reporter |
RKSimon
|
To fix a crash reported in #142937, #142939 added handling for llvm.type.test in SelectionDAGBuilder.cpp.
But as @pcc explained here: https://github.com/llvm/llvm-project/pull/142939#issuecomment-3808771304
> This intrinsic was deliberately unhandled in SDAG so that we would crash if LowerTypeTests was accidentally never added to the pass pipeline. Can we instead mark LowerTypeTests as isRequired so that it won't be skipped by pass bisection?
We should ensure that LowerTypeTests is always run and remove the code added in #142939 - the test case should be adjusted as necessary, to ensure #142937 doesn't crash.
![]()
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
