| Issue |
185250
|
| Summary |
[MLIR] Crash in AffineParallelLowering when creating arith::ConstantOp
|
| Labels |
mlir
|
| Assignees |
|
| Reporter |
jiayiw2008
|
Hi, I encountered a crash bug when lowering a gpu program to nvvm, please see the following code example:
Git version: 47766d7f8c397da857d9f78db36c71e8a2ca1fbf
```llvm
module {
gpu.module @gemv_execution_module {
gpu.func @row_parallel_gemv(%n: i32, %A: memref<?x?xi8>, %x: memref<?xi8>, %result: memref<?xi32>) {
%tid = gpu.thread_id x
%bid = gpu.block_id x
%tid_i32 = arith.index_cast %tid : index to i32
%bid_i32 = arith.index_cast %bid : index to i32
%global = arith.addi %bid_i32, %tid_i32 : i32
%global_idx = arith.index_cast %global : i32 to index
%n_idx = arith.index_cast %n : i32 to index
%active = arith.cmpi ult, %global_idx, %n_idx : index
scf.if %active {
%c0_i32 = arith.constant 0 : i32
%c1_i32 = arith.constant 1 : i32
%c0_idx = arith.constant 0 : index
%c1_idx = arith.constant 1 : index
%n_cast = arith.index_cast %n : i32 to index
%summation = scf.for %col = %c0_idx to %n_cast step %c1_idx iter_args(%accum = %c0_i32) -> (i32) {
%a_byte = memref.load %A[%global_idx, %col] : memref<?x?xi8>
%x_byte = memref.load %x[%col] : memref<?xi8>
%a_int = arith.extsi %a_byte : i8 to i32
%x_int = arith.extsi %x_byte : i8 to i32
%mul = arith.muli %a_int, %x_int : i32
%new_accum = arith.addi %accum, %mul : i32
scf.yield %new_accum : i32
}
memref.store %summation, %result[%global_idx] : memref<?xi32>
}
gpu.return
}
}
func.func @host_side_gemv(%n: i32, %A: memref<?x?xi8>, %x: memref<?xi8>, %result: memref<?xi32>) {
%c0_i32 = arith.constant 0 : i32
%c1_i8 = arith.constant 1 : i8
%c1_i32 = arith.constant 1 : i32
%n_idx = arith.index_cast %n : i32 to index
%sum = affine.parallel (%r) = (0) to (%n_idx) reduce ("assign") -> i32 {
%row_idx = affine.apply affine_map<(d0) -> (d0)>(%r)
%c0_idx = arith.constant 0 : index
%col_idx_cast = arith.index_cast %n : i32 to index
%c1_idx = arith.constant 1 : index
%row_sum = scf.for %c = %c0_idx to %col_idx_cast step %c1_idx iter_args(%inner_sum = %c0_i32) -> (i32) {
%col_idx = affine.apply affine_map<(d0) -> (d0)>(%c)
%a = memref.load %A[%row_idx, %col_idx] : memref<?x?xi8>
%xv = memref.load %x[%col_idx] : memref<?xi8>
%a_ext = arith.extsi %a : i8 to i32
%x_ext = arith.extsi %xv : i8 to i32
%product = arith.muli %a_ext, %x_ext : i32
%new_sum = arith.addi %inner_sum, %product : i32
scf.yield %new_sum : i32
}
memref.store %row_sum, %result[%row_idx] : memref<?xi32>
affine.yield %row_sum : i32
}
return
}
func.func @task_dispatcher(%task_sizes: memref<?xi8>, %task_ids: memref<?xi8>,
%num_tasks: i8, %num_threads: i8) {
%threshold = arith.constant 50 : i8
%c0_i8 = arith.constant 0 : i8
%c1_i8 = arith.constant 1 : i8
%c0_idx = arith.constant 0 : index
%c1_idx = arith.constant 1 : index
%num_tasks_idx = arith.index_cast %num_tasks : i8 to index
scf.for %i = %c0_idx to %num_tasks_idx step %c1_idx iter_args(%processed = %c0_i8) -> (i8) {
%i_i32 = arith.index_cast %i : index to i32
%i_i8 = arith.trunci %i_i32 : i32 to i8
%size = memref.load %task_sizes[%i] : memref<?xi8>
%assigned = arith.remui %i_i8, %num_threads : i8
%large = arith.cmpi sgt, %size, %threshold : i8
%updated_count = arith.addi %processed, %c1_i8 : i8
%result = scf.if %large -> (i8) {
scf.yield %updated_count : i8
} else {
scf.yield %processed : i8
}
scf.yield %result : i8
}
func.return
}
}
```
#### Stack Trace
```bash
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace and instructions to reproduce the bug.
Stack dump:
0. Program arguments: ./mlir-opt UnifiedMemoryStreams.mlir -lower-affine -gpu-lower-to-nvvm-pipeline
#0 0x0000589acc7e0bed llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /llvm/lib/Support/Unix/Signals.inc:880:11
#1 0x0000589acc7e111b PrintStackTraceSignalHandler(void*) /llvm/lib/Support/Unix/Signals.inc:962:1
#2 0x0000589acc7defb4 llvm::sys::RunSignalHandlers() /llvm/lib/Support/Signals.cpp:108:5
#3 0x0000589acc7e18b9 SignalHandler(int, siginfo_t*, void*) /llvm/lib/Support/Unix/Signals.inc:448:38
#4 0x0000742d68645330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330)
#5 0x0000742d6869eb2c __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
#6 0x0000742d6869eb2c __pthread_kill_internal ./nptl/pthread_kill.c:78:10
#7 0x0000742d6869eb2c pthread_kill ./nptl/pthread_kill.c:89:10
#8 0x0000742d6864527e raise ./signal/../sysdeps/posix/raise.c:27:6
#9 0x0000742d686288ff abort ./stdlib/abort.c:81:7
#10 0x0000589acc7b9985 llvm::report_fatal_error(llvm::Twine const&, bool) /llvm/lib/Support/ErrorHandling.cpp:137:5
#11 0x0000589acc7b99d9 (./mlir-opt+0x47ea9d9)
#12 0x0000589adb34561f (./mlir-opt+0x1337661f)
#13 0x0000589adad05bf6 mlir::arith::ConstantOp::build(mlir::OpBuilder&, mlir::OperationState&, mlir::TypedAttr) /build/tools/mlir/include/mlir/Dialect/Arith/IR/ArithOps.cpp.inc:4187:1
#14 0x0000589adacd6fea mlir::arith::ConstantOp::create(mlir::OpBuilder&, mlir::Location, mlir::TypedAttr) /build/tools/mlir/include/mlir/Dialect/Arith/IR/ArithOps.cpp.inc:4192:47
#15 0x0000589adace5c23 mlir::arith::getIdentityValue(mlir::arith::AtomicRMWKind, mlir::Type, mlir::OpBuilder&, mlir::Location, bool) /mlir/lib/Dialect/Arith/IR/ArithOps.cpp:2794:10
#16 0x0000589ad58fd179 (anonymous namespace)::AffineParallelLowering::matchAndRewrite(mlir::affine::AffineParallelOp, mlir::PatternRewriter&) const /mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp:234:11
#17 0x0000589ad590602b mlir::detail::OpOrInterfaceRewritePatternBase<mlir::affine::AffineParallelOp>::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&) const /mlir/include/mlir/IR/PatternMatch.h:299:12
#18 0x0000589adb03c738 mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>)::$_0::operator()() const /mlir/lib/Rewrite/PatternApplicator.cpp:223:31
#19 0x0000589adb03c3e5 void llvm::function_ref<void ()>::callback_fn<mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>)::$_0>(long) /llvm/include/llvm/ADT/STLFunctionalExtras.h:46:5
#20 0x0000589acc806fb9 llvm::function_ref<void ()>::operator()() const /llvm/include/llvm/ADT/STLFunctionalExtras.h:69:5
#21 0x0000589adb03df3b void mlir::MLIRContext::executeAction<mlir::ApplyPatternAction, mlir::Pattern const&>(llvm::function_ref<void ()>, llvm::ArrayRef<mlir::IRUnit>, mlir::Pattern const&) /mlir/include/mlir/IR/MLIRContext.h:291:3
#22 0x0000589adb03a7ca mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>) /mlir/lib/Rewrite/PatternApplicator.cpp:242:9
#23 0x0000589adafb1088 (anonymous namespace)::OperationLegalizer::legalizeWithPattern(mlir::Operation*) /mlir/lib/Transforms/Utils/DialectConversion.cpp:2831:21
#24 0x0000589adafa51a2 (anonymous namespace)::OperationLegalizer::legalize(mlir::Operation*) /mlir/lib/Transforms/Utils/DialectConversion.cpp:2609:17
#25 0x0000589adafb0afd (anonymous namespace)::OperationLegalizer::legalizeWithFold(mlir::Operation*) /mlir/lib/Transforms/Utils/DialectConversion.cpp:2678:12
#26 0x0000589adafa50eb (anonymous namespace)::OperationLegalizer::legalize(mlir::Operation*) /mlir/lib/Transforms/Utils/DialectConversion.cpp:2599:19
#27 0x0000589adafa4a72 mlir::OperationConverter::convert(mlir::Operation*, bool) /mlir/lib/Transforms/Utils/DialectConversion.cpp:3309:26
#28 0x0000589adafa5b3d llvm::LogicalResult mlir::OperationConverter::legalizeOperations<mlir::OperationConverter::applyConversion(llvm::ArrayRef<mlir::Operation*>)::$_0>(llvm::ArrayRef<mlir::Operation*>, mlir::OperationConverter::applyConversion(llvm::ArrayRef<mlir::Operation*>)::$_0, bool) /mlir/lib/Transforms/Utils/DialectConversion.cpp:3410:16
#29 0x0000589adafa56ee mlir::OperationConverter::applyConversion(llvm::ArrayRef<mlir::Operation*>) /mlir/lib/Transforms/Utils/DialectConversion.cpp:3456:26
#30 0x0000589adafb656c applyConversion(llvm::ArrayRef<mlir::Operation*>, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig, (anonymous namespace)::OpConversionMode)::$_0::operator()() const /mlir/lib/Transforms/Utils/DialectConversion.cpp:4179:30
#31 0x0000589adafb64d5 void llvm::function_ref<void ()>::callback_fn<applyConversion(llvm::ArrayRef<mlir::Operation*>, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig, (anonymous namespace)::OpConversionMode)::$_0>(long) /llvm/include/llvm/ADT/STLFunctionalExtras.h:46:5
#32 0x0000589acc806fb9 llvm::function_ref<void ()>::operator()() const /llvm/include/llvm/ADT/STLFunctionalExtras.h:69:5
#33 0x0000589adafd28d3 void mlir::MLIRContext::executeAction<ApplyConversionAction>(llvm::function_ref<void ()>, llvm::ArrayRef<mlir::IRUnit>) /mlir/include/mlir/IR/MLIRContext.h:291:3
#34 0x0000589adafa92e8 applyConversion(llvm::ArrayRef<mlir::Operation*>, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig, (anonymous namespace)::OpConversionMode) /mlir/lib/Transforms/Utils/DialectConversion.cpp:4183:1
#35 0x0000589adafa919c mlir::applyPartialConversion(llvm::ArrayRef<mlir::Operation*>, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig) /mlir/lib/Transforms/Utils/DialectConversion.cpp:4192:10
#36 0x0000589adafa9385 mlir::applyPartialConversion(mlir::Operation*, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig) /mlir/lib/Transforms/Utils/DialectConversion.cpp:4199:10
#37 0x0000589ad58f6b50 (anonymous namespace)::LowerAffine::runOnOperation() /mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp:564:16
#38 0x0000589adb0fe1d4 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int)::$_3::operator()() const /mlir/lib/Pass/Pass.cpp:0:19
#39 0x0000589adb0fe175 void llvm::function_ref<void ()>::callback_fn<mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int)::$_3>(long) /llvm/include/llvm/ADT/STLFunctionalExtras.h:46:5
#40 0x0000589acc806fb9 llvm::function_ref<void ()>::operator()() const /llvm/include/llvm/ADT/STLFunctionalExtras.h:69:5
#41 0x0000589adb10167b void mlir::MLIRContext::executeAction<mlir::PassExecutionAction, mlir::Pass&>(llvm::function_ref<void ()>, llvm::ArrayRef<mlir::IRUnit>, mlir::Pass&) /mlir/include/mlir/IR/MLIRContext.h:291:3
#42 0x0000589adb0f561e mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) /mlir/lib/Pass/Pass.cpp:619:17
#43 0x0000589adb0f5d3a mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) /mlir/lib/Pass/Pass.cpp:688:16
#44 0x0000589adb0fb61d mlir::PassManager::runPasses(mlir::Operation*, mlir::AnalysisManager) /mlir/lib/Pass/Pass.cpp:1123:10
#45 0x0000589adb0faba6 mlir::PassManager::run(mlir::Operation*) /mlir/lib/Pass/Pass.cpp:1097:60
#46 0x0000589acc8ebb9b performActions(llvm::raw_ostream&, std::shared_ptr<llvm::SourceMgr> const&, mlir::MLIRContext*, mlir::MlirOptMainConfig const&) /mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:596:17
#47 0x0000589acc8eb271 processBuffer(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::MemoryBufferRef, mlir::MlirOptMainConfig const&, mlir::DialectRegistry&, mlir::SourceMgrDiagnosticVerifierHandler*, llvm::ThreadPoolInterface*) /mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:681:12
#48 0x0000589acc8eaf2c mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::$_0::operator()(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::MemoryBufferRef, llvm::raw_ostream&) const /mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:779:12
#49 0x0000589acc8eae36 llvm::LogicalResult llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::MemoryBufferRef const&, llvm::raw_ostream&)>::callback_fn<mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::$_0>(long, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::MemoryBufferRef const&, llvm::raw_ostream&) /llvm/include/llvm/ADT/STLFunctionalExtras.h:46:12
#50 0x0000589adb6669da llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::MemoryBufferRef const&, llvm::raw_ostream&)>::operator()(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::MemoryBufferRef const&, llvm::raw_ostream&) const /llvm/include/llvm/ADT/STLFunctionalExtras.h:69:12
#51 0x0000589adb665d9a mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::MemoryBufferRef const&, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef) /mlir/lib/Support/ToolUtilities.cpp:30:12
#52 0x0000589acc8e6ae6 mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&) /mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:784:26
#53 0x0000589acc8e6ee8 mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&) /mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:830:14
#54 0x0000589acc8e70b8 mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&) /mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:846:10
#55 0x0000589acc7b57d5 main /mlir/tools/mlir-opt/mlir-opt.cpp:343:33
#56 0x0000742d6862a1ca __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
#57 0x0000742d6862a28b call_init ./csu/../csu/libc-start.c:128:20
#58 0x0000742d6862a28b __libc_start_main ./csu/../csu/libc<truncated>Please see the issue for the entire body.
![]()
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
