On Sep 11, 2007, at 2:40 PM, Daniel Berlin wrote:

> On 9/11/07, Chris Lattner <[EMAIL PROTECTED]> wrote:
>>> URL: http://llvm.org/viewvc/llvm-project?rev=41855&view=rev
>>> Log:
>>> Convert to use ilist and non-pointer lists for extra goodness
>>
>> Yay!
>>
>>> +  // Dump our bits to stderr
>>> +  void dump(llvm::OStream &out) const {
>>> +    out << "[ ";
>>> +    for (iterator bi = begin();
>>> +         bi != end();
>>> +         ++bi) {
>>> +      out << *bi << " ";
>>> +    }
>>> +    out << std::endl;
>>> +  }
>>
>> Please don't use std::endl, use '\n' instead.  Could this be moved
>> out of line?
>
> Done and done (I'll commit when i get home)

Thanks!

-Chris
_______________________________________________
llvm-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Reply via email to