On Oct 10, 2007, at 9:33 AM, Evan Cheng wrote: > My only concern is it won't look as pleasant if the function name is > long.
Which happens with C++ mangled names all the time :( a potentially solution to this (which may be over complex :) is to have two options: 1. if the name is short, print it as you propose. 2. if the name is long, print it with a number and optionally with a subset of the name (last 10 chars?) This could be implemented by just adding a new ivar like CurrentFunctionName that holds this. -Chris > > Evan > > On Oct 10, 2007, at 7:36 AM, Dan Gohman <[EMAIL PROTECTED]> wrote: > >> The attached patch changes the names of internal labels used by >> codegen. In place of the "function number", which is a number that >> codegen itself assigns specifically for this purpose, it uses the >> (mangled) name of the function, which is already sufficiently unique. >> >> For example, what currently looks like this: >> .LCPI1_3: >> where 1 is the function number and 3 is the constant index would >> look like this: >> .LCPI3_foo: >> Note that the constant index is now first, so the name can go last >> to avoid problems with names containing underscores. >> >> I saw this in another compiler and liked it. Does anyone here >> dislike it? >> >> Dan >> >> -- >> Dan Gohman, Cray Inc. >> <patch.labels> >> _______________________________________________ >> llvm-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits > _______________________________________________ > llvm-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits _______________________________________________ llvm-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
