On 11/13/07, Owen Anderson <[EMAIL PROTECTED]> wrote: > On Nov 13, 2007, at 5:04 PM, Hartmut Kaiser wrote: > > - return iterator(this, ~0); > > + return iterator(this, true); > > I'm not sure this is right. Is "true" guaranteed to be all-ones when > cast to an integer, or just to contain at least one 1 bit? If the > latter, then this patch changes the meaning.
At one point, this patch would have been very broken (also, ~0 is not strange for unsigned int, it's used all the time to get the largest unsigned number that fits in the datatype). I have since changed the iterator to track the end differently, and removed the ability to get an iterator at any random point in the bitmap, so the parameter ~0 is being passed for is now a true/false variable. > > --Owen > _______________________________________________ > llvm-commits mailing list > llvm-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits > > > _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
