http://llvm.org/bugs/show_bug.cgi?id=3758

           Summary: SmallVector::grow/swap should be shared for POD T's
           Product: libraries
           Version: 1.0
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core LLVM classes
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]


Looking at the exported symbol map of a couple of tools, I see a ton of things
like this:

       llvm::SmallVectorImpl<clang::ProgramPoint>::grow(unsigned long)
       llvm::SmallVectorImpl<clang::QualType>::grow(unsigned long)
       llvm::SmallVectorImpl<clang::Selector>::grow(unsigned long)
       llvm::SmallVectorImpl<clang::SourceLocation>::grow(unsigned long)
       llvm::SmallVectorImpl<clang::Stmt*>::grow(unsigned long)
       llvm::SmallVectorImpl<clang::StringLiteral*>::grow(unsigned long)
       llvm::SmallVectorImpl<clang::SwitchStmt*>::grow(unsigned long)
       llvm::SmallVectorImpl<clang::Token>::grow(unsigned long)
      
llvm::SmallVectorImpl<clang::Token>::operator=(llvm::SmallVectorImpl<clang::Token>
const&)

These are all POD types, and there is no reason for them to all get their own
copy of these (somewhat large) methods.  We only need to instantiate grow/swap
etc when T requires copy ctors etc.


-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
LLVMbugs mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/llvmbugs

Reply via email to