http://llvm.org/bugs/show_bug.cgi?id=20652
Bug ID: 20652
Summary: arm asm: .arch_extension toggles aren't right
Product: libraries
Version: trunk
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P
Component: LLVM assembly language parser
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]
Classification: Unclassified
r214057 added this code:
+ bool ToggleFeatures = EnableFeature
+ ? (~STI.getFeatureBits() & Extension.Features)
+ : ( STI.getFeatureBits() & Extension.Features);
+ if (ToggleFeatures) {
+ unsigned Features =
+ ComputeAvailableFeatures(STI.ToggleFeature(Extension.Features));
+ setAvailableFeatures(Features);
+ }
If any bit needs to be toggled, it toggles all of them. That doesn't look
right.
I think this would be better:
+ unsigned ToggleFeatures = EnableFeature
+ ? (~STI.getFeatureBits() & Extension.Features)
+ : ( STI.getFeatureBits() & Extension.Features);
+ unsigned Features =
+ ComputeAvailableFeatures(STI.ToggleFeature(ToggleFeatures));
+ setAvailableFeatures(Features);
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
LLVMbugs mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/llvmbugs
