https://llvm.org/bugs/show_bug.cgi?id=23199

            Bug ID: 23199
           Summary: Discriminators are added to the line table more often
                    than necessary
           Product: libraries
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: DebugInfo
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected],
                    [email protected], [email protected],
                    [email protected], [email protected]
    Classification: Unclassified

As discussed on the list [1], we add discriminators to line table entries more
often than necessary.  There may be some downstream users (e.g., Linux perf)
depending on the weak checks -- they should be fixed, and then we should fix
our code to only add discriminators when the entries can't already be
discriminated.

Currently, we check:

  - filename
  - line

We should also check:

  - column
  - discriminator
  - directory

I'll add FIXMEs to the code and mention this PR when I transition the current
functionality from DILocation over to MDLocation.

[1]:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150406/270650.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
LLVMbugs mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/llvmbugs

Reply via email to