Hi Torsten, Am Sonntag, 25. Oktober 2009 18:02:03 schrieb Torsten Duwe: > I found LMMS did not include one of my favority synths, the DX7 > emulator "hexter" http://dssi.sourceforge.net/hexter.html , > so I hacked up some glue to achieve this. Great stuff - thanks :) I just took a rough look at the sources. If you plan this to be integrated into LMMS finally your source should match LMMS' coding style guidelines (see Wiki) - mainly indentation currently is broken in your files. Use tab for each level of indentation (with ts=4 code should look fine).
However my concerns are dependencies of Hexter, especially Gtk. At least if you plan to integrate the GUI as well, things will get complicated. The win32 build of LMMS will never be shipped with all the Gtk libraries. > My main goal was to alter the hexter source as little as possible, in order > to benefit from any future development easily. Most of the work was simply > understanding and finding the APIs; If you could drop a note somewhere > e.g. in the README that says "the documentation is in the headers, RTFS" > that would help a lot to get started ;-) Submit a patch ;) > Even there I couldn't find a clear description of what exactly an > overloaded instrument::play() method is expected to do, I hope I got it > correct. Please comment! Looks fine from what I saw.. > I would also like to hear some comments on the concepts of hexter > "instances" versus the LMMS plugin, and its own handling of "global" > polyphony, as well as the program changes possible for MIDI instruments. One Hexter instance per LMMS plugin instance should be fine. Keep up the work and I'll do a detailled review of a re-submitted patch later. :) Toby
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference
_______________________________________________ LMMS-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmms-devel
