Hi, It helps, I've made a little change to avoid the case where i < key % cap
if( chord->hasSemiTone( ( i + cap - ( key % cap ) ) % cap ) ) Works also well with chords marking On Thu, Mar 1, 2012 at 11:08 PM, Tobias Doerffel <[email protected]> wrote: > Hi, > > 2012/3/1 Raine M. Ekman <[email protected]>: >> The formula in the scale marking code (src/gui/piano_roll.cpp) is screwed: >> >> if( chord->hasSemiTone( std::abs( key - i ) % cap ) ) >> >> should really be something like this: >> >> if( chord->hasSemiTone( ( i - ( key % cap ) ) % cap ) ) > > Without having taken a look at it in detail - if it solves the > problem, we should change it accordingly! Can someone verify that this > change helps? > > Toby > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > LMMS-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/lmms-devel ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ LMMS-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmms-devel
