Hi, Ok, thank you. It's effectively a quite large commit, next time I will make one "atomic" change per commit.
On Sat, Oct 27, 2012 at 10:35 PM, Tobias Doerffel <[email protected]> wrote: > Hi! > > thank you very much for this awesome piece of work! I'm really sorry > that my response is delayed that much.. Anyways I finally found some > time to look at your patch, even though I did not make a deep code > review. However from what I can see everything seems to be realized in > a clean manner. One small wish for the next time: splitting up the > changes into a patch series (e.g. by the individual changes mentioned > in your commit log). > > The patch has been applied and pushed and will be part of the next release. > > Toby > > > 2012/2/21 S . <[email protected]>: >> Hi guys, >> >> Here is a patch which contains ergonomic enhancements for >> AudioFileProcessor plugin by making the wave view interactive thus >> allowing zooming, sliding view and sample start/end points (fully tied >> with knobs). It also display more information: sample length & note >> play progression. >> >> I find this very useful for picking a small sample in a large audio file. >> >> I also ask for a code review, as I'm not sure that I have implemented >> the play progression in the best way (with a signal emitted from >> plugin's playNote()). >> >> Regards >> ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ LMMS-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmms-devel
