Hi, 2013/7/23 Johannes Lorenz <[email protected]>: > However, I do not understand the code. In saveSettings() and loadSettings(), > there are "modified Controllers" saved. Why does it not suffice to just call > this: > > m_portamentoModel.saveSettings() ? >
According to git blame: ----------------------- commit bac2b28ad723abfc5980c7b38045481ca69b16d4 Author: Tobias Doerffel <[email protected]> Date: Thu Sep 2 17:12:50 2010 +0200 ZynAddSubFX: save which controllers were modified and restore them We must not only restore the controller knobs but also send updates to ZynAddSubFX. However this only applies to knobs that were modified. Therefore save and remember which knobs this applies for. ----------------------- The logic which loads the settings in loadSettings() restores the models settings *before* instantiating the real ZASF instrument. This way custom values in the models like portamento etc. would not be sent to the instrument. We therefore send according updates afterwards. However I do not know why we do not simply call m_*Model.loadSettings() at the end and let everything else being managed by connected slots (updatePortamento() etc.). Maybe you can test this a little bit and provide some improvements here. Besides this the mentioned bug is not related to this issue (and has been fixed just a few minutes ago BTW :-) Best regards Toby ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ LMMS-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmms-devel
