A few quick points for now:
- Maybe change bar:beat:ms display to bar:beat:ticks, and add some
easy way to distinguish between the now identical-looking modes, like
different separators, e.g. 01:02:03 for seconds and 01.02.03 for beats?
- Looks like the beat position isn't updated when dragging the play
head around while stopped. Shouldn't be a big thing to change?
With those changes, I think the beat display works well enough. And I
think you've mentioned all the problems I could see in the real time
display so far, so I have nothing to add on that front for now.
Quoting Rubén Ibarra Pastor <pastor...@msn.com>:
> It does work with tempo automation while you play a song. But when
> you are not playing it and change the tempo the time stays the same
> and this causes problems with seeking. When you play a song and seek
> it can cause problems too but this is because I don't know if this
> should be dealt by adding the points in the automation or use a
> cycle(There are many ways to deal with this, is just to know which
> is the correct one).
>
> About standarizing the names. Of course I can change the name. What
> is needed for the package to be accepted in our tree and give the
> actual timer development for accepted? Would it be accepted part by
> part or it needs more things? I think part by part would be ok so
> there would be more cooperation and to deliver more features to the
> users and git testers.
>
>
>
>
>
> Rubén Ibarra Pastor
>
>
>
>
>> Date: Thu, 25 Jul 2013 22:36:56 +0200
>> From: tobias.doerf...@gmail.com
>> To: pastor...@msn.com
>> CC: lmms-devel@lists.sourceforge.net
>> Subject: Re: [LMMS-devel] Timer Patch(tested on Git version and
>> fixed errors marked by Raine)
>>
>> Hi Rubén,
>>
>> thanks for the patch! Does it work properly in conjunction with tempo
>> automation? Also could you please change the class member variables to
>> follow LMMS' coding style guidelines ("m_fooBar" instead of "foobar").
>> Besides this good job, thanks a lot!
>>
>> Best regards
>>
>> Toby
>>
>> ------------------------------------------------------------------------------
>> See everything from the browser to the database with AppDynamics
>> Get end-to-end visibility with application monitoring from AppDynamics
>> Isolate bottlenecks and diagnose root cause in seconds.
>> Start your free trial of AppDynamics Pro today!
>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> _______________________________________________
>> LMMS-devel mailing list
>> LMMS-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/lmms-devel
>
--
ra...@iki.fi
04 00 83 83 95
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
LMMS-devel mailing list
LMMS-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lmms-devel
