On 12 January 2014 19:53, Tobias Doerffel <tobias.doerf...@gmail.com> wrote:
> You don't have to take care of key press events anymore at all - everything
> is in place already. In paintEvent() you have to retrieve the Piano model
> instance via
>
> pattern->instrumentTrack()->pianoModel()
>
> and retrieve the current key states via a yet to be implemented public
> "isKeyPressed( int key ) const" method (and once you are at it, modify
> PianoView such that it doesn't need to be a friend class of Piano anymore).


I'm almost done with this patch. :)
Now the key presses are visible in the Piano Roll by all the three methods.
On the note of highlighting the row, I guess it is not really
necessary since our mouse when held on the note editor area highlights
the current row already.
So how should this patch review be done? Shall I send the pull request?

-- 
Gurjot Singh
Blog: http://bhattigurjot.wordpress.com

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
LMMS-devel mailing list
LMMS-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lmms-devel

Reply via email to