So, I had a look at grid drawing in the Automation Editor lately, related to issue #283. The problem there comes from the X coordinates being calculated in too many places: both in the timeline and in the grid.
What I'm thinking of doing is moving all the time<->X coordinate conversions into one place, which would then be called from whichever editor is showing a grid (song, piano or automation). This will be good for a future addition of better time signature changes as well. Might fix issue #303 in the same process. Possible ways: 1. Move all this calculation into the timeline 2. Create a new class for this, used by both the timeline and the grids 3. Create a GridEditor class that the other editors inherit and fix this there Option 3 smells like a major rewrite of all editors, so that might need some more planning and discussion. And I'm not even sure they have that much in common apart from the timeline. Unless something like that is already in the works, I could do 1 or 2 "soon", i.e. after 1.0.0. No point rushing this IMO, as it for now solves small problems that have been in there "forever". Toby, are there any developments underway that have to be taken into account? Opinions, OO guidelines? https://github.com/LMMS/lmms/issues/283 https://github.com/LMMS/lmms/issues/303 -- [email protected] softrabbit on #lmms ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ LMMS-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmms-devel
