On 03/28/2014 02:26 PM, Raine M. Ekman wrote: > Quoting Vesa <[email protected]>: >> To properly implement a release phase for a sustain loop, the length of >> note release would need to be dependent on the note frequency, but I >> don't currently see a way to do this. There's desiredReleaseFrames() >> which is meant to return the desired frame amount, but it doesn't take a >> note handle as an argument so can't be informed of the frequency of the >> note... > So, what's missing is something like: > NotePlayHandle::setReleaseFrames(const f_cnt_t _frames) > > or: > Instrument::desiredReleaseFrames(pitch) > > ...right? At a glance, both look easy enough to implement. >
More like, Instrument::desiredReleaseFrames( NotePlayHandle _n ) ...because we'd also have to take in consideration the position in the sample. But just modifying desiredReleaseFrames wouldn't be enough, whatever part of the note playing code that decides how long to keep calling playNote would need to be modified, also, every other instrument plugin that uses desiredReleaseFrames... like I said, too much trouble IMO just for this feature. ------------------------------------------------------------------------------ _______________________________________________ LMMS-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmms-devel
