Quoting Tres Finocchiaro <tres.finocchi...@gmail.com>: > Thanks Yann. > > The vast majority of those (about 307 of them, or 90%) are introduced with > some older 3rd party LADSPA plugins, namel: > > - 67% - SWH LADSPA Plugin > - 12% - Tap LADSPA Plugin > - 7% Calf LADSPA Plugin > - 4% Zyn Instrument Plugin > > - 10% LMMS source
I'd advise caution in tackling this. Almost 80% of the report lists dead assignments, increments and initializations, i.e. code that runs but the results are thrown away. Those are rarely actual bugs, but if you go in and start fixing to get CLang to shut up you might create bugs. Keep in mind that preprocessor macros are not accounted for, see e.g. https://github.com/LMMS/lmms/blob/master/plugins/opl2/fmopl.c#L1311 where CLang says "Value stored to 'ptr' is never read", but it will be read if you turn BUILD_Y8950 on. > > If someone is familiar with fixing these types of issues, please do help > and we'll be happy to help get the fixes into the codebase. Please note, > ffor the 3rd party bugs, we try to file them upstream too via something > like https://github.com/swh/ladspa/commits. > > Also, if someone decides to take a crack at the SWH plugins per the > author, the code is built from XML source, using Perl and XML::Parser, so > it will look a bit different upstream. > > -Tres > > > > > - tres.finocchi...@gmail.com > > On Thu, May 14, 2015 at 8:31 AM, Yann Collette <ycollette.nos...@free.fr> > wrote: > >> Hello, >> >> I build LMMS from git repo using clang scan build on fedora 21 64 bits >> with clang-3.5. >> The log of the scan build is available on >> http://ycollette.free.fr/LMMS/scan-build-2015-05-14-134424-1529-1.tar.gz >> This report can be opened using firefox on the file >> scan-build-2015-05-14-134424-1529-1/index.html >> >> The command line I used for the scan-build: >> mkdir build_cland >> cd build_clang >> cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo >> -DCMAKE_INSTALL_PREFIX=/local/stow/lmms-devel-clang >> -DCMAKE_C_COMPILER=/usr/libexec/clang-analyzer/scan-build/ccc-analyzer >> -DCMAKE_CXX_COMPILER=/usr/libexec/clang-analyzer/scan-build/c++-analyzer .. >> >> I used cmake-gui to activate WANT_VST_NOWINE. >> >> Then, start the build using "scan-build make" in the build directory. >> >> There are some good reports about null pointer dereference, unused >> variables, uninitialized variables ... >> >> Best regards, >> >> YC >> >> >> ------------------------------------------------------------------------------ >> One dashboard for servers and applications across Physical-Virtual-Cloud >> Widest out-of-the-box monitoring support with 50+ applications >> Performance metrics, stats and reports that give you Actionable Insights >> Deep dive visibility with transaction tracing using APM Insight. >> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y >> _______________________________________________ >> LMMS-devel mailing list >> LMMS-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/lmms-devel >> > -- ra...@iki.fi softrabbit on #lmms ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ LMMS-devel mailing list LMMS-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lmms-devel
