In SVN trunk now:
 
OK Crisis averted. Synths fixed.
But overall issue maybe not completely banished.

I corrected the situation by having all getPatchName() methods
 return QString instead of const char*.
 
I was not fond of doing that for the MESS synths - I was aiming
 to not make them even more dependent on Qt by returning QString.
But I see that they already are dependent on Qt, either using 
 Qt components or being passed QString parameters by MusE.

I /could/ have continued to let the MESS synths return const char*.
Then the MESS owner SIF's method "QString getPatchName()"  would  
 convert the return value of the MESS's "const char* getPatchName()" 
 into QString, and away we go. Fine. No Prob.
Because, no MESS synth uses QStrings to store their patch names ATM.
For ex. Deicsonze uses std::string.

However, *if* a MESS synth were to be created or modified to use
 QStrings for their list of patch names, then *boom* We'd hit this 
 same bug asking for a patch name because we'd be doing:

        QString > const char* > QString

 and this reconversion to QString is what Qt doesn't seem to like here.

Fortunately this usage counts as an easily fixable redundancy. 

Obviously, this goes for the ENTIRE app too. We must check other 
 places and be wary of this kind of usage.
Which is why I say the issue may not completely banished...

Carry on.
Tim.

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Lmuse-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmuse-developer

Reply via email to