Am 19.05.2013 22:52, schrieb Robert Jonsson:
> Hi,
> 
> 
> 2013/5/19 Florian Jung <[email protected]>
> 
>> Hi
>>
>> moving to git is a good opportunity for altering history. Would you like
>> me to fix the indentation of all .cpp and .h files by piping it through
>> indent or some similar program?
>>
>> this will affect all commits, also those in the past. While this
>> obviously means changing history, it does not involve one large "coding
>> style" commit which would break diff-ing revisions.
>>
>>
>> In my opinion, the indentation is pretty insane, but of course I'll wait
>> for your agreement :)
>>
>>
>> how about only indenting with tabs, and coding style like this:
>>
>> int function() {
>>         stuff;
>>         goes();
>>         if (some && condition) {
>>                 foo();
>>         }
>>         return here;
>> }
>>
>> ?
>>
> 
> I really dislike the BSD-style code so I'm not against removing that but
> making automatic changes have not worked that well for me in the past...

first, this is GNU indent, so we can use whatever options this tool
supports. kdevelop's indenting feature would really rock, but i guess
this cannot be called on the CLI.

> 
> Not sure what you mean by "changing history"? Would we be able to keep the
> history and invisibly change the indentation?
> Sounds like magic ;)

git is a bit of magic :)

"changing history" means:
1) i convert svn to git, and have the weird indentation
2) i run a tool that takes every commit, runs a program (in this case,
indent) on this commit, and replaces the original commit with the result
of this progra,.
3) now, the "old" history with strange indentation is lost.

> 
> Tim has coded lots more of the code so his word is heavier than mine, by
> far :)

of course. As indentation is a matter of taste, i don't want to do
anything without asking you first :)
Tim?

greetings
flo

> 
> Regards,
> Robert
> 
> 
>> greetings,
>> flo
>>
>>
> 


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Lmuse-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmuse-developer

Reply via email to