2013/6/24 Florian Jung <[email protected]>: > excerpt of the code: > > bool MusE::importWaveToTrack(QString& name, unsigned tick, > MusECore::Track* track) > { > if (track==NULL) > track = (MusECore::WaveTrack*)(_arranger->curTrack()); > > MusECore::SndFileR f = MusECore::getWave(name, true); > > track->setChannels(f->channels()); // TODO oh really? don't we > want to keep the setting as it was before? (comment by flo) > > > why do we override the track's number of channels there? IMHO, this is > fine as long the number of channels hasn't changed yet. But if i import > one Stereo wave, and afterwards one mono wave, i don't want the track to > be reset to mono
Right. Seems halfway intelligent since it tries to adjust after what is imported but it breaks down when you import more. > > Does this have a deeper sense i don't get? No, I think you are right. Better to let it keep the created number of channels. If the user wants to change it, just click the button. Regards, Robert > Greetings > flo > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > Lmuse-developer mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/lmuse-developer ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Lmuse-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmuse-developer
