Hey! (sorry for answering only sporadically, but I'll try to answer at least every couple of days!)
On 10/07/2015 01:52 PM, Caba wrote: > 4.- "Looking at it now I see that it doesn't inherit from MidiEditor but > rather from TopWin, > I suppose it is quite different from the other midi editors". > > Sure, I understand that this difference was, maybe, because of lacking > of documentation, or maybe, he decided it that way. > > Florian, could you clarify this item? IIRC, the MidiEditor class uses some notion of "events are objects with a position, a height and a width". I.e. by rectangular things, that are rendered the one way (rectangle=pianoroll) or another (diamonds=drum editor). They fit in some sort of grid. the score editor does not fit there at all. > 5.- "I'm not sure if your drum additions (that was your idea, right?) > will be a part of the Score editor or if there will be a new editor with > specifically drum edits?" > > I don't know it yet, I'll have to read code parts several times. I strongly suggest to add this to the score editor. It should be as "easy"[tm] as extending the FloEvent class/struct by some attribute like "note head" in addition to length and note pitch / position in the staff for displaying, and some special handling for editing. I don't think that a separate editor will do anything good except duplicating a lot of code Cheers Florian ------------------------------------------------------------------------------ _______________________________________________ Lmuse-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmuse-developer
