Hey! Remember when I said recently in the issue tracker
that this thing was driving me nuts, that the new sliders
were not being given full vertical space when put into a layout,
and thus my focus rectangles were not being fully drawn?
Bug!
In (non-knob) derivatives of SliderBase we have like this:
void Slider::setMargins(int hor, int vert)
{
d_xMargin = MusECore::qwtMax(0, hor);
d_yMargin = MusECore::qwtMin(0, vert);
resize(this->size());
}
Spot the error?
Second line should be this:
d_yMargin = MusECore::qwtMax(0, vert);
The Slider and all classes involved like scale, markings, range etc.
are very old code, dating back to 1997!
(Notice the qwt prefixes, eh?)
All these years that bug was there!
Fixed in all classes. Will push soon.
I've already had to update some of the obsolete code,
and now I've souped it up with better markings etc.
I combined what Andrew did with his volume sliders, with...
... Well, you'll see.
After finally getting the colours to play nice with styles
and our stylesheets, I can say I'm pleased with the mixer
look and how it worked out.
I hope you will be too.
It looks super-cool with our Ardour and Dark stylesheets,
and plays nice with styles, even the ugly Windows style,
with its unusual (challenging) dark purple highlight colour.
Push soon...
Tim.
------------------------------------------------------------------------------
_______________________________________________
Lmuse-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmuse-developer
