Hi Tim,
2016-04-29 16:55 GMT+02:00 Tim E. Real <[email protected]>:
> Everyone is advised to pull this from the git master.
>
> *Important bug fix: About two dozen CORRUPT usages of
> QByteArray::constData().
> In: routepopup.cpp lv2host.cpp helper.cpp dssihost.cpp jackmidi.cpp
> conf.cpp
> vst_native.cpp minstrument.cpp
>
> We were doing things like:
> const char* cstr = qstring.toLatin1().constData();
> printf(cstr);
> Which is a no-no. The QByteArray is out of scope.
> [Raises hand.] "My bad recently too. It's easy to forget that rule.
> We fixed so verrrry many of those things after the move to Qt4."
>
> Symptoms could vary wildly. They might happen frequently or not at all.
> On my system MusE steadfastly refused to load the config file -
> a mere dozen or so lines of code into the application.
> Oops!
> It was always starting with a blank config meaning all dialogs popping up
> and Transport window always opening.
>
> Other possible symptoms: Weird corrupted text in places, Jack connection
> problems, midi controller corruption, LV2, DSSI, or native VST controller
> or text corruption and so on, not to mention any secondary effects of
> passing around corrupt strings.
> I checked all 566 instances of the text ".constData" and fixed the bad
> ones.
>
Ouch and oh... I can definitely see myself having contributed... Now that
you mention it I recall the problem though.
Let's hope this is related to some of the wierd problems observed lately.
>
> If MusE has behaved strangely for you in the last few years or even
> earlier,
> this might explain it.
>
> - Fixed compile stoppage due to latest Jack obsoleting
> jack_port_set_name().
> Created 'dlopen' function pointers for jack_port_set_name() and the
> brand new jack_port_rename(), and arbitrated between them.
>
> - Disable ElidedLabel auto-font size for now (midi strip
> instrument/patch labels).
>
> Thanks.
> Tim.
>
Awesome!
/Robert
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Lmuse-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmuse-developer
