FYI I updated my audio_convert branch as well,
although not with these three recent 'quickies',
hang in there, will do...
The branch still works.
On this new PC, I loaded up several of my old
songs from CD#2 (2006), which was recorded at
48000Hz on a SoundBlaster Live!, way back
when I was into that onboard DSP and so on.
These days I run at 44100Hz.
The songs contain dozens of tracks, and takes
and retakes, kept for posterity sake.
Without doing much except setting up my midi device,
the songs play, with reasonable DSP usage.
I noticed a few mistakes with 'split' parts and so on,
but it works. I'll try to get back into that branch.
A lot of work went into it, there are other
important 'fixes', or improvements, in there as well.
Not that it will go into master any time real soon,
there's much more to do.
Let me put it this way: So far, it COULD go into master
and the automatic sample-rate conversion will
'just work' for everyone, and I could sort of disable
the other stretching/shifting stuff for now. We'll see...
Tim.
On 2017-04-09 04:40 PM, Tim wrote:
On 2017-04-09 04:07 PM, Robert Jonsson wrote:
Hi guys,
sorry being late to the show. I had this problem also, on one
computer, not on the other, same distro,.. kubuntu 16.10, but
apparently with some difference.
Your latest checkin fixed it.
The other computer had another issue, I had to add curly braces in
astrip.cpp, the compiler complained that indentation was not right.
This is probably a warning and I'm guessing I'm compiling with debug
which defines -Werror to treat warnings as errors.
Ha! I'm always in debug mode.
I notice in release mode, like other apps, there a
heck of a lot of silly complaints about unused
return values - well duh, of course I'm not using them,
I wrote it that way, ha ha...
OK that's very weird spamatica.
Talk about a Draconian compiler -
complaining about indentation!
I've pushed the fix.
Plus, just in case, I put QString() around that QChar
'cause I noticed there didn't seem to be a
QString::operator+(QChar), so just to be clear about it.
Thanks for your help guys.
Lemme know if anything else, I'm here.
Should... release... RC2... sometime... this year... eh?
Tim.
--- a/muse3/muse/mixer/astrip.cpp
+++ b/muse3/muse/mixer/astrip.cpp
@@ -274,14 +274,14 @@void AudioComponentRack::newComponent(
ComponentDescriptor* desc, const Componen
{
case aStripAuxComponent:
{
- if(d->_compactKnob->specialValueText().isEmpty())
+ if(d->_compactKnob->specialValueText().isEmpty()) {
d->_compactKnob->setSpecialValueText(QString('-') +
QChar(0x221e)); // The infinity character
-
- connect(d->_compactKnob,
SIGNAL(valueStateChanged(double,bool,int,int)),
SLOT(auxChanged(double,bool,int,int)));
- connect(d->_compactKnob,
SIGNAL(sliderMoved(double,int,bool)), SLOT(auxMoved(double,int,bool)));
- connect(d->_compactKnob, SIGNAL(sliderPressed(double,
int)), SLOT(auxPressed(double, int)));
- connect(d->_compactKnob, SIGNAL(sliderReleased(double,
int)), SLOT(auxReleased(double, int)));
- connect(d->_compactKnob,
SIGNAL(sliderRightClicked(QPoint,int)),
SLOT(auxRightClicked(QPoint,int)));
+ }
+ connect(d->_compactKnob,
SIGNAL(valueStateChanged(double,bool,int,int)),
SLOT(auxChanged(double,bool,int,int)));
+ connect(d->_compactKnob,
SIGNAL(sliderMoved(double,int,bool)), SLOT(auxMoved(double,int,bool)));
+ connect(d->_compactKnob, SIGNAL(sliderPressed(double,
int)), SLOT(auxPressed(double, int)));
+ connect(d->_compactKnob, SIGNAL(sliderReleased(double,
int)), SLOT(auxReleased(double, int)));
+ connect(d->_compactKnob,
SIGNAL(sliderRightClicked(QPoint,int)),
SLOT(auxRightClicked(QPoint,int)));
}
break;
}
@@ -313,14 +313,14 @@void AudioComponentRack::newComponent(
ComponentDescriptor* desc, const Componen
{
case aStripAuxComponent:
{
- if(d->_compactSlider->specialValueText().isEmpty())
+ if(d->_compactSlider->specialValueText().isEmpty()) {
d->_compactSlider->setSpecialValueText(QString('-') +
QChar(0x221e)); // The infinity character
-
- connect(d->_compactSlider,
SIGNAL(valueStateChanged(double,bool,int,int)),
SLOT(auxChanged(double,bool,int,int)));
- connect(d->_compactSlider,
SIGNAL(sliderMoved(double,int,bool)), SLOT(auxMoved(double,int,bool)));
- connect(d->_compactSlider, SIGNAL(sliderPressed(double,
int)), SLOT(auxPressed(double, int)));
- connect(d->_compactSlider, SIGNAL(sliderReleased(double,
int)), SLOT(auxReleased(double, int)));
- connect(d->_compactSlider,
SIGNAL(sliderRightClicked(QPoint,int)),
SLOT(auxRightClicked(QPoint,int)));
+ }
+ connect(d->_compactSlider,
SIGNAL(valueStateChanged(double,bool,int,int)),
SLOT(auxChanged(double,bool,int,int)));
+ connect(d->_compactSlider,
SIGNAL(sliderMoved(double,int,bool)), SLOT(auxMoved(double,int,bool)));
+ connect(d->_compactSlider, SIGNAL(sliderPressed(double,
int)), SLOT(auxPressed(double, int)));
+ connect(d->_compactSlider, SIGNAL(sliderReleased(double,
int)), SLOT(auxReleased(double, int)));
+ connect(d->_compactSlider,
SIGNAL(sliderRightClicked(QPoint,int)),
SLOT(auxRightClicked(QPoint,int)));
}
break;
}
~
I didn't check it in, are the braces at the right place?
Regards,
Robert
2017-04-09 18:31 GMT+02:00 Tim <[email protected]
<mailto:[email protected]>>:
Hi, sorry about that, I always struggle with the
'inline' keyword.
Strange it compiles here. Maybe I still missed something?
Try it now, I moved the function body into the header.
Thanks.
Tim.
On 2017-04-09 05:55 AM, Michael Oswald wrote:
> Hi Time,
>
> On 2017-04-09 01:19, Tim wrote:
>> Hi, there was a dependency on Qt 5.5 in there.
>> I guess you aren't running that recent a version?
>
> Ubuntu Studio 14.04 uses 5.2.1
>
>> Try it now, I removed the line. That control isn't
>> used at all yet anyway so it doesn't matter.
>>
>> But maybe you will get more errors...
>
> It compiles now, but I get a link error:
>
> [100%] Building CXX object muse/CMakeFiles/muse.dir/main.o
> Linking CXX executable muse3
> libmuse_core.so: undefined reference to
> `MusECore::MidiController::dValToInt(double)'
> collect2: error: ld returned 1 exit status
> make[2]: *** [muse/muse3] Error 1
> make[1]: *** [muse/CMakeFiles/muse.dir/all] Error 2
> make: *** [all] Error 2
>
>
> lg,
> Michael
>
>
>
>> Thanks.
>> Tim.
>>
>> On 2017-04-08 03:47 PM, Michael Oswald wrote:
>>> Hi Time,
>>>
>>> For some reason, it doesn't compile on my machine:
>>>
>>>
/home/oswald/Projects/music/muse/muse3/muse/widgets/text_edit.cpp: In
>>> member function ‘virtual QSize MusEGui::TextEdit::sizeHint()
const’:
>>>
/home/oswald/Projects/music/muse/muse3/muse/widgets/text_edit.cpp:66:36:
>>>
>>> error: ‘viewportMargins’ was not declared in this scope
>>> viewportMargins().bottom() +
>>> viewportMargins().top() +
>>> ^
>>> [ 66%]
>>>
/home/oswald/Projects/music/muse/muse3/muse/widgets/text_edit.cpp:70:1:
>>> warning: control reaches end of non-void function [-Wreturn-type]
>>> }
>>> ^
>>> make[2]: ***
[muse/widgets/CMakeFiles/widgets.dir/text_edit.o] Error 1
>>> make[2]: *** Waiting for unfinished jobs....
>>>
>>>
>>> I have had only a brief look and didn't find a suspect, any idea?
>>>
>>> lg,
>>> Michael
>>>
>>>
>>>
>>>
>>>
>>> On 2017-04-08 18:34, Tim wrote:
>>>> Oops!
>>>>
>>>> 5 minutes later, in foolish confidence, I simply clicked
>>>> File > New > Audio.med > change wave track 1 to stereo.
>>>>
>>>> Crashes soon after.
>>>>
>>>> Took two days to track this puppy down.
>>>> Insidious silent data corruption. And of course my fault,
>>>> in the worst possible place, the low-level audio engine.
>>>>
>>>> This crash bug is about about one year old.
>>>>
>>>> If you experienced any crashes simply by changing
>>>> an audio track from mono <> stereo, this was likely it.
>>>>
>>>> Tim.
>>>>
>>>>
>>>> ChangeLog:
>>>> - Crash fix: File > New > Audio.med > change wave track 1 to
stereo ->
>>>> crashes soon after.
>>>> In AudioTrack::copyData(): In two sections concerning
'2ch' ->
>>>> '1ch'
>>>> mixing:
>>>> Move 'sp' inside channel loop. Was allowed to increment
beyond,
>>>> into
>>>> other variable data, causing silent corruption.
>>>> - Also, fixed template "audo.med": Both audio output track's
outputs
>>>> were routed to same jack port.
>>>>
>>>>
>>>>
------------------------------------------------------------------------------
>>>>
>>>>
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> Lmuse-developer mailing list
>>>> [email protected]
<mailto:[email protected]>
>>>> https://lists.sourceforge.net/lists/listinfo/lmuse-developer
<https://lists.sourceforge.net/lists/listinfo/lmuse-developer>
>>>>
>>>
>>>
------------------------------------------------------------------------------
>>>
>>>
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Lmuse-developer mailing list
>>> [email protected]
<mailto:[email protected]>
>>> https://lists.sourceforge.net/lists/listinfo/lmuse-developer
<https://lists.sourceforge.net/lists/listinfo/lmuse-developer>
>>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Lmuse-developer mailing list
[email protected]
<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/lmuse-developer
<https://lists.sourceforge.net/lists/listinfo/lmuse-developer>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Lmuse-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmuse-developer
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Lmuse-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmuse-developer
