On 11/05/2017 06:17 PM, Krzysztof Gajdemski wrote:
Hello,
05.11.2017, 21:44:55, Tim wrote:
> Hi, try it now.
Patched, compiled and tested. All problematic controllers are recorded
now. Wow, that was fast! I always knew that MusE has an excellent
support! Funny, I just started to investigate that exact part of the
code but without a solid understating of MusE internals it was hard to
provide working patch.
> I cherry picked a fix from my branch midi_engine_fixes_2017.
> I was aware of this issue soon after starting the branch and
> had fixed it there, hoping to merge soon at the time, but
> long time has passed now.
So what about merging that and doing official MusE release soon? From my
point of view (thanks to latest commits) it's getting pretty stable now.
Last official release is quite dated and muse_3_0_pre2 has lots of bugs
comparing to master…
[ Pardon the CC to our dev list, not sure who receives what. ]
Merge may happen soon. As of today I finished some more heavy work.
It compiles, plays complex test songs, and record tests OK.
I rewrote my clumsy multi-writer-thread MPSC ring buffer template class.
It's not a ring buffer, per se:
One item array.
One atomic bool inUse array.
One atomic bool hasData array.
No counters, pointers, increments, modulos etc. Just 'bins' !
The trick is, thankfully, for safety and assurance the reader side
needed to sort what it read from the buffer, by midi event timestamp.
So it simply empties the event 'bins' into a sorted memory-pooled set.
Now for the first time I just stress tested my branch.
So far solid no concurrency issues. Wish me luck...
Cheers.
Tim.
> Apologies for any hassle.
> And for accidentally closing the issue, simply by including
> the words "Fix #592" in my commit line. Hmm, kinda neat,
> it highlights the word "Fix" in the Git browser and takes you
> right to the fix.
Yeah, some sophisticated AI stuff for everyone. :)
Thanks and best regards,
k.
--
Krzysztof Gajdemski | songo (at) debian.org.pl | KG4751-RIPE
Registered Linux User #133457 | BLUG Registered Member #0005
PGP key at: http://s.debian.org.pl/gpg/gpgkey * ID: D3259224
Szanuję was wszystkich, którzy pozostajecie w cieniu - Snerg
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<https://github.com/muse-sequencer/muse/issues/592#issuecomment-342014264>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFK9Gprtw3krGsDeF0OGqjoWh8dGygJ5ks5szkIigaJpZM4QSbB6>.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Lmuse-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmuse-developer
