Hi Ola, It is difficult to comment on the code if it comes in attachment. Normal policy even for RFC is to create patch and send it inline.
As far as feedback goes. It seems to me that your proposal is a bit overloaded. I am not sure that we need concept of source and separation to different subsystems in ODP layer. I don't think we could get different implementations to provide consistent list of sources. But if it is not the case how can system that uses ODP write the same code that would work with different implementations? Also as far as level concerned I am not sure about that either. Two level debug and error are sort of obvious, more levels than that I am not sure. Requirement to hook up logging to external handlers does exits. Thanks, Victor On 18 August 2014 07:17, Ola Liljedahl <[email protected]> wrote: > I wanted some feedback. Are people happy with the current log support in > ODP? (I think I have seen some complaints, thus my proposal). Do people have > any specific requirements on logging? > Here are the requirements I have heard: > 1) Log messages must be associated with different severity levels. > 2) Possibility to run-time enable/disable logging per-module and > per-severity. Personally I think it is important to keep logging available > in the system even if dormant. So dormant logging must have very low > overhead. > 3) Possibility to compile-time disable some/all logging for lowest overhead. > Should this option be per-module and/or per severity? > 4) Forward ODP log messages to external log framework. > > > What's the possibility/probability that someone else takes this API and > writes a proper implementation and provides the patch? Or is it expected > that the same person always does all the steps? > > -- Ola > > > On 18 August 2014 15:32, Mike Holmes <[email protected]> wrote: >> >> Hey Ola, >> >> Any chance of a patch ;) >> Maybe we can pull this together as part of a series that updates >> global_init. >> >> >> On 15 August 2014 11:17, Ola Liljedahl <[email protected]> wrote: >>> >>> (This document/code contribution attached is provided under the terms of >>> agreement LES-LTM-21309) >>> >>> I contribute a proposal for a log API for ODP to stimulate further >>> discussion. >>> >>> Some comments: >>> Header file missing compile-time selection of log/severity levels, left >>> as an exercise to the mailing list. >>> Implementation is not thread safe but that should be easy to fix, >>> thread-unsafe operations are not performance critical so some coarse locking >>> should be fine. >>> Example usage in log_example.c. This is really the important part. >>> >>> Build with >>> gcc -std=c99 -Wall odp_log.c log_example.c -o log_example >>> >>> There might be one thing that is GCC-specific, see if you can find it. >>> >>> -- Ola >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> [email protected] >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> >> -- >> Mike Holmes >> Linaro Technical Manager / Lead >> LNG - ODP > > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
