No, I presume that if you think it needs a clean up, then that much at least is needed now. I was just hopeful that the follow on discussion to accepting it in the repo as a base line would focus on functional issues for LCU. I just think that the perfect vs base lined argument falls on base lined in this case.
Mike On 19 August 2014 13:55, Robbie King (robking) <[email protected]> wrote: > Hey Mike, sorry to be dense here. Are you saying I should forgo > restructuring > > the code and lets get the patch out ASAP? > > > > *From:* Mike Holmes [mailto:[email protected]] > *Sent:* Tuesday, August 19, 2014 10:08 AM > *To:* Robbie King (robking) > *Cc:* lng-odp-forward ([email protected]) > *Subject:* Re: [lng-odp] ODP IPSec example application code structure > > > > I think your best estimate is going to be appropriate. > > > > I believe given that this app is functional on multiple platforms and we > know it works, we should shy away from being extremely picky on style at > this point, it is a large app to review. > > We have already said that it can be omitted from being referenced from the > ODP_API in doxygen, something that a later patch could address, bearing in > mind the issues Tarras raised about the API doc picking up to many > superfluous example structures. > > > > I think the import issue is to get the fully functional app into the repo, > and then into CI so that by December any changes we make are easily > synchronized across platforms and checked for regressions. > > > > I believe if Bala, Taras, Alex all give their tested-by signoff we should > take this in as the first cut. > > > > Mike > > > > On 19 August 2014 09:17, Robbie King (robking) <[email protected]> wrote: > > Hi all, I have a very general question about the ipsec application. I > would like to facilitate getting > > it reviewed and in to the repository ASAP (connect is less than four weeks > away, yikes!). > > > > I realize one 3,000+ line file is not very good form, but different folks > have different ideas > > about how something should be broken up. I was considering doing > something like the > > following. > > > > odp_ipsec.c – main ODP application code, i.e. the meat of the program > > > > and putting all the table management, helper routines into .h/.c pairs: > > > > odp_ipsec_sa_db.h – prototypes and doxygen for SA database > > odp_ipsec_sa_db.c – implementations for SA database > > odp_ipsec_sp_db.h – prototypes and doxygen for SP database > > odp_ipsec_sp_db.c – implementations for SP database > > … etc… > > > > This would probably result in a dozen or so reasonably sized files. I > would like to avoid doing > > all this refactoring only to ignite a debate on code structure. J > > > > Thanks! > > Robbie > > > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > > > > > > -- > > *Mike Holmes* > > Linaro Technical Manager / Lead > > LNG - ODP > -- *Mike Holmes* Linaro Technical Manager / Lead LNG - ODP
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
