Thanks Taras.  I can add the polling vs scheduling
logic back, I didn't realize you needed it.

I created the large number of patches to facilitate
the review process, however I can merge them easily
(I think, I know just enough about git rebase to 
be dangerous).  

If no one else objects, I will add the scheduling logic
back and merge the patches, then resend later today.

-----Original Message-----
From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] 
Sent: Thursday, August 21, 2014 11:20 AM
To: Robbie King (robking); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH 00/13] IPsec example application

Hi Robbie

On 08/21/2014 03:30 PM, Robbie King wrote:
> Hello all,
>
> Here is the refactored IPsec example application.
>
> Changes from the existing github version are:
>   - Split into multiple source/header files
>   - Support for querying MAC address via pktio handle
>   - Removed unused test code for scheduling

It was used by me, but anyway it is not a part of the application.

>   - Adding ability to set packet flags (for steam packets)
>     to allow packet processing code to verify ETH packets
>     regardless of source (interface versus loop)
>   - Requires a per packet user context (part of patch)
>   - Update .gitignore to exclude ID file
>
> Robbie King (13):
>    Add user context to packet
>    Add helper include file with IPSec headers
>    Add ability to set packet flags
>    Add IPsec example app to build environment

I think patches below should be merged into patch above as they form an
atomic part. On each patch sources should be compilable for
bisectability. Which is not the case now.

>    IPsec example app main program
>    IPsec example app support routines
>    IPsec example app SA/SP/route cache
>    IPsec example IPv4 forwarding DB
>    IPsec example SA DB
>    IPsec example SP DB
>    IPsec example loopback interface DB
>    IPsec example stream DB and check/verify
>    IPsec example app README and test scripts
>
>   .gitignore                                         |    2 +
>   configure.ac                                       |    1 +
>   example/Makefile.am                                |    2 +-
>   example/ipsec/Makefile.am                          |   12 +
>   example/ipsec/README                               |  164 +++
>   example/ipsec/odp_ipsec.c                          | 1444 
> ++++++++++++++++++++
>   example/ipsec/odp_ipsec_cache.c                    |  178 +++
>   example/ipsec/odp_ipsec_cache.h                    |  127 ++
>   example/ipsec/odp_ipsec_fwd_db.c                   |  133 ++
>   example/ipsec/odp_ipsec_fwd_db.h                   |   89 ++
>   example/ipsec/odp_ipsec_loop_db.c                  |   54 +
>   example/ipsec/odp_ipsec_loop_db.h                  |  128 ++
>   example/ipsec/odp_ipsec_misc.h                     |  321 +++++
>   example/ipsec/odp_ipsec_sa_db.c                    |  162 +++
>   example/ipsec/odp_ipsec_sa_db.h                    |   77 ++
>   example/ipsec/odp_ipsec_sp_db.c                    |  124 ++
>   example/ipsec/odp_ipsec_sp_db.h                    |   71 +
>   example/ipsec/odp_ipsec_stream.c                   |  534 ++++++++
>   example/ipsec/odp_ipsec_stream.h                   |  133 ++
>   example/ipsec/run_ah_in.sh                         |   12 +
>   example/ipsec/run_ah_out.sh                        |   12 +
>   example/ipsec/run_both_in.sh                       |   14 +
>   example/ipsec/run_both_out.sh                      |   14 +
>   example/ipsec/run_esp_in.sh                        |   13 +
>   example/ipsec/run_esp_out.sh                       |   13 +
>   example/ipsec/run_live.sh                          |   17 +
>   example/ipsec/run_router.sh                        |    9 +
>   example/ipsec/run_simple.sh                        |   10 +
>   include/helper/odp_ipsec.h                         |   73 +
>   include/odp_packet.h                               |   18 +
>   include/odp_packet_flags.h                         |  136 ++
>   .../linux-generic/include/odp_packet_internal.h    |    2 +
>   platform/linux-generic/odp_packet.c                |   10 +
>   platform/linux-generic/odp_packet_flags.c          |   88 ++
>   34 files changed, 4196 insertions(+), 1 deletions(-)
>   create mode 100644 example/ipsec/Makefile.am
>   create mode 100644 example/ipsec/README
>   create mode 100644 example/ipsec/odp_ipsec.c
>   create mode 100644 example/ipsec/odp_ipsec_cache.c
>   create mode 100644 example/ipsec/odp_ipsec_cache.h
>   create mode 100644 example/ipsec/odp_ipsec_fwd_db.c
>   create mode 100644 example/ipsec/odp_ipsec_fwd_db.h
>   create mode 100644 example/ipsec/odp_ipsec_loop_db.c
>   create mode 100644 example/ipsec/odp_ipsec_loop_db.h
>   create mode 100644 example/ipsec/odp_ipsec_misc.h
>   create mode 100644 example/ipsec/odp_ipsec_sa_db.c
>   create mode 100644 example/ipsec/odp_ipsec_sa_db.h
>   create mode 100644 example/ipsec/odp_ipsec_sp_db.c
>   create mode 100644 example/ipsec/odp_ipsec_sp_db.h
>   create mode 100644 example/ipsec/odp_ipsec_stream.c
>   create mode 100644 example/ipsec/odp_ipsec_stream.h
>   create mode 100644 example/ipsec/run_ah_in.sh
>   create mode 100644 example/ipsec/run_ah_out.sh
>   create mode 100644 example/ipsec/run_both_in.sh
>   create mode 100644 example/ipsec/run_both_out.sh
>   create mode 100644 example/ipsec/run_esp_in.sh
>   create mode 100644 example/ipsec/run_esp_out.sh
>   create mode 100644 example/ipsec/run_live.sh
>   create mode 100644 example/ipsec/run_router.sh
>   create mode 100644 example/ipsec/run_simple.sh
>   create mode 100644 include/helper/odp_ipsec.h
>

_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to