On 28 August 2014 12:24, Anders Roxell <[email protected]> wrote:

> On 2014-08-25 22:06, Anders Roxell wrote:
> > Signed-off-by: Anders Roxell <[email protected]>
> > ---
> >  platform/linux-dpdk/odp_linux.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/platform/linux-dpdk/odp_linux.c
> b/platform/linux-dpdk/odp_linux.c
> > index 067bd99..a694f65 100644
> > --- a/platform/linux-dpdk/odp_linux.c
> > +++ b/platform/linux-dpdk/odp_linux.c
> > @@ -78,6 +78,7 @@ void odp_linux_pthread_create(odp_linux_pthread_t
> *thread_tbl, int num,
> >                               odp_run_start_routine(start_args);
> >                       lcore_config[cpu].state = FINISHED;
> >               }
> > +             free(start_args);
>
No, this should not be done. start_args gets dereferenced in the function
given to pthread. Freeing it here will cause a crash. For eg.,
thr_args->dstpktio is done in pktio_ifburst_thread function of odp_l2fwd.c.

> >       }
> >  }
> >
> > --
> > 1.9.1
> >
>
> Ping.
>
> _______________________________________________
> lng-odp mailing list
> [email protected]
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to