I think the consensus was to fix up Stuarts comments and apply this, bearing in mind that Taras will have to completely replace global_init for his platform, and that may be true for others so only dpdk will benefit from the refactoring for now.
The goal for apply this patch as is being to allow DPDK folks to get their parameters passed correctly via global init. On 27 August 2014 10:39, Taras Kondratiuk <[email protected]> wrote: > On 08/27/2014 03:16 PM, Taras Kondratiuk wrote: > >> On 08/26/2014 07:03 PM, Mike Holmes wrote: >> >>> Signed-off-by: Mike Holmes <[email protected]> >>> --- >>> >>> v2: >>> Factor out odp_platform_init so that odp_global_init is only defined >>> for linux_generic and resued. >>> >> >> Hi Mike >> >> I doubt it is worth to reuse odp_init_global() from linux-generic. >> Initialization won't always follow init steps in the same order as >> linux-generic. Also you will have to reuse odp_init_local() and add all >> steps there, because you don't know which part of initialization need >> to be called for each thread. >> > > By making a generic odp_init_local() KS2 specific one is removed, so > ti_em_rh_init_local() is not called any more. > -- *Mike Holmes* Linaro Technical Manager / Lead LNG - ODP
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
