We are requiring all internal header files to have "odp_" prefix? Isn't it enough that they are included using "" and not <> which is used for system header files? The priority_queue is not an ODP construct, it is completely generic. It is like a library function except it does not exist in any external library. Maybe it should be located in a separate directory though, e.g. platform/linux-generic/utility or even on a top-level utility library?
And why putting .h files in a separate directory? They are part of the implementation just like the .c files (so private, not public). Definitions move between the .c and the .h files as needed. Why are the .c files located in the same directory as the Makefile and a bunch of TEXT files? What makes the internal header files special compared to all other internal files? -- Ola On 4 September 2014 09:58, Savolainen, Petri (NSN - FI/Espoo) < [email protected]> wrote: > > platform/linux-generic/priority_queue.h > > Should be moved and renamed to > > platform/linux-generic/include/odp_priority_queue_internal.h > > or something similar. All ODP headers have either odp_ or odph_ prefix so > that it easy to see with are ODP vs. c lib/linux/posix includes. > > > -Petri > > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp >
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
