> -----Original Message----- > From: ext Maxim Uvarov [mailto:[email protected]] > Sent: Monday, September 08, 2014 1:18 PM > To: Savolainen, Petri (NSN - FI/Espoo); Bala Manoharan > Cc: lng-odp-forward > Subject: Re: [lng-odp] [PATCH v2 1/2] Shared memory reserve flag > > On 09/08/2014 11:40 AM, Savolainen, Petri (NSN - FI/Espoo) wrote: > > > >> -----Original Message----- > >> From: [email protected] [mailto:lng-odp- > >> [email protected]] On Behalf Of ext Maxim Uvarov > >> Sent: Monday, September 08, 2014 9:31 AM > >> To: Bala Manoharan > >> Cc: lng-odp-forward > >> Subject: Re: [lng-odp] [PATCH v2 1/2] Shared memory reserve flag > >> > >> On 09/08/2014 09:30 AM, Bala Manoharan wrote: > >>> Hi, > >>> > >>> A Few queries from my side, > >>> > >>> * ODP_SHM_PROC: In this case we need a mechanism to allow ODP process > >>> to be able to do a lookup of shared memory created by process outside > >>> of ODP. Current odp_shm_lookup only checks shm created by ODP process. > >> Yes. And this is process odp_shm_reserve(). You can take a look how I > do > >> it for IPC in ipc patches. You need to call odp_shm_reserve() in 2 > >> process with the same "name" argument. > > Do we want to support shm created outside of ODP? Since ODP does not > have full control over that memory, ODP cannot guarantee that application > can use it in a portable way. Maybe it's better to operate such memory > outside of ODP. > > > > If decided to support in ODP, it should be clearly separate from ODP > controlled shm. > > > > -Petri > > > > I think it should be part of ODP. I.e. application developer should not > care about allocation models, functions or any hw specific things like > CMA. It should be platform specific thing. And application should be the > same for all platforms. > > Maxim. >
ODP won't be OS abstraction. If some shared memory was created outside of ODP (e.g. by a ctrl app), ODP implementation does not know about it or have control over it, so it should passed to the ODP app also outside of ODP. It's safe assumption, that ODP API can be used only for memory that is created/controlled through ODP. How and where non-ODP apps find that (ODP controlled) memory is implementation/system specific. Are we now ready to merge this patch? -Petri _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
