On 2014-09-10 18:27, Bill Fischofer wrote: > Pre v1.0 changes may be incompatible but the author should coordinate with > affected modules to ensure that when applied the result is an ODP that > compiles and is functional.
I disagree with you here. I don't think the author of this patch has to do that. However, the author of the apps that uses ODP should _only_ use released versions of ODP and not be on latest. If they are on latest they should know that things will/can change. Cheers, Anders > > Bill > > On Wednesday, September 10, 2014, Mike Holmes <[email protected]> > wrote: > > > Isn't that the point of the pre 1.0 SW so that we reorganize as we evolve > > to some thing we say will remain stable? > > On Sep 9, 2014 6:08 PM, "Maxim Uvarov" <[email protected] > > <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > > > >> This patch will break odp apps which use helpers. > >> > >> Maxim. > >> > >> On 09/04/2014 11:23 PM, Anders Roxell wrote: > >> > >>> Signed-off-by: Anders Roxell <[email protected] > >>> <javascript:_e(%7B%7D,'cvml','[email protected]');>> > >>> --- > >>> platform/linux-dpdk/Makefile.am | 2 +- > >>> platform/linux-generic/Makefile.am | 2 +- > >>> platform/linux-keystone2/Makefile.am | 2 +- > >>> 3 files changed, 3 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/ > >>> Makefile.am > >>> index a59435f..3787dc9 100644 > >>> --- a/platform/linux-dpdk/Makefile.am > >>> +++ b/platform/linux-dpdk/Makefile.am > >>> @@ -52,7 +52,7 @@ include_HEADERS = \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_timer.h \ > >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ > >>> version.h > >>> -subdirheadersdir = $(includedir)/helper > >>> +subdirheadersdir = $(includedir) > >>> subdirheaders_HEADERS = \ > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > >>> $(top_srcdir)/helper/include/odph_eth.h \ > >>> diff --git a/platform/linux-generic/Makefile.am > >>> b/platform/linux-generic/Makefile.am > >>> index 25c82ea..7b4522e 100644 > >>> --- a/platform/linux-generic/Makefile.am > >>> +++ b/platform/linux-generic/Makefile.am > >>> @@ -40,7 +40,7 @@ include_HEADERS = \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_pktio_netmap.h \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_pktio_socket.h > >>> -subdirheadersdir = $(includedir)/helper > >>> +subdirheadersdir = $(includedir) > >>> subdirheaders_HEADERS = \ > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > >>> $(top_srcdir)/helper/include/odph_eth.h \ > >>> diff --git a/platform/linux-keystone2/Makefile.am > >>> b/platform/linux-keystone2/Makefile.am > >>> index 027c035..54bce26 100644 > >>> --- a/platform/linux-keystone2/Makefile.am > >>> +++ b/platform/linux-keystone2/Makefile.am > >>> @@ -55,7 +55,7 @@ include_HEADERS = \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_timer.h \ > >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ > >>> version.h > >>> -subdirheadersdir = $(includedir)/helper > >>> +subdirheadersdir = $(includedir) > >>> subdirheaders_HEADERS = \ > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > >>> $(top_srcdir)/helper/include/odph_eth.h \ > >>> > >> > >> > >> _______________________________________________ > >> lng-odp mailing list > >> [email protected] > >> <javascript:_e(%7B%7D,'cvml','[email protected]');> > >> http://lists.linaro.org/mailman/listinfo/lng-odp > >> > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp -- Anders Roxell [email protected] M: +46 709 71 42 85 | IRC: roxell _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
