On 7 October 2014 09:15, Balasubramanian Manoharan <[email protected]> wrote: > This patch provides ODP macro for unimplemented function > > Signed-off-by: Balasubramanian Manoharan <[email protected]> > --- > platform/linux-generic/include/api/odp_debug.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/platform/linux-generic/include/api/odp_debug.h > b/platform/linux-generic/include/api/odp_debug.h > index 344b0a9..bb67cef 100644 > --- a/platform/linux-generic/include/api/odp_debug.h > +++ b/platform/linux-generic/include/api/odp_debug.h > @@ -82,6 +82,13 @@ do { fprintf(stderr, "%s:%d:%s(): " fmt, __FILE__, \ > } while (0) > > /** > + * This macro is used to indicate when a given function is not implemented > + */ > +#define ODP_UNIMPLEMENTED() \ > + fprintf(stderr, "%s:%d:The function %s() is yet to be implemented", \ > + __FILE__, __LINE__, __func__);
Please don't use unsolicited fprintf, instead use proper logging call. That could be redirected in the future. Also it is very strange to see such definition in *api* header file. If it is utility macro to help implement standard message from unimplemented functions it should be placed properly - in some header file that only implementations can see. Thanks, Victor > + > +/** > * Print output to stderr (file, line and function), > * then abort. > */ > -- > 2.0.1.472.g6f92e5f > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
