Gets my vote On 13 October 2014 06:38, Maxim Uvarov <[email protected]> wrote:
> On 10/13/2014 12:22 PM, Bala Manoharan wrote: > >> Hi All, >> >> If no one has any objections I will move ODP_UNIMPLEMENTED/ODP_ERR and >> ODP_ABORT into odp_debug_internal.h file and provide a new patch. >> I will also remove "fprintf" from individual macros and implement a macro >> ODP_LOG? >> >> Pls let me know if there are any concerns for the above suggestion. >> >> Regards, >> Bala >> > > Yes, I think it's reasonable. Nothing stops us in future to put that to > global api. So let's do it for linux-generic and if there will not be > changes for other applications we can move that to global include. > > Maxim. > > > >> On 10 October 2014 16:59, Mike Holmes <[email protected] <mailto: >> [email protected]>> wrote: >> >> Looks like something of a deeper move does not fall out that >> easily, so I also vote for >> linux-generic/include/odp_debug_internal.h to get this in. >> >> On 10 October 2014 04:20, Savolainen, Petri (NSN - FI/Espoo) >> <[email protected] <mailto:[email protected]>> wrote: >> >> >> >> From: ext Mike Holmes [mailto:[email protected] >> <mailto:[email protected]>] >> Sent: Friday, October 10, 2014 2:21 AM >> To: Savolainen, Petri (NSN - FI/Espoo) >> Cc: ext Bala Manoharan; Bill Fischofer; >> [email protected] <mailto:[email protected]> >> Subject: Re: [lng-odp] [ODP/PATCH 2/2 v1] ODP Macro for >> unimplemented function >> >> >> >> On 9 October 2014 02:43, Savolainen, Petri (NSN - FI/Espoo) >> <[email protected] <mailto:[email protected]>> >> >> wrote: >> “api-internal” does not make sense. There’s no “internal >> application programming interface”. If ABORT/ERR/etc are >> removed from the API, then those are just part of the >> implementation. It’s not very productive to try to standardize >> the implementation. We can place those macros in linux-generic >> so that those are easy find, but each implementation re-uses >> those at own risk. >> >> If those are removed from odp_debug.h, a natural place to put >> those would be linux-generic/include/odp_debug_internal.h >> Ok so drop api, I could see that making sense. >> >> it still feels redundant to have a long list of files all >> adding "_internal.h" mixed in with those that do not have it, >> if they are different in some way, why not capture that fact >> once in another directory and remove the repeated "_internal" >> text from each file name ? >> >> Currently in linux-generic/include/ >> >> odp_packet_internal.h >> odp_queue_internal.h >> odp_buffer_internal.h >> odp_packet_io_internal.h >> odp_schedule_internal.h >> odp_buffer_pool_internal.h >> odp_spin_internal.h >> odp_timer_internal.h >> odp_crypto_internal.h >> >> AND >> >> odp_packet_io_queue.h >> odp_packet_netmap.h >> odp_internal.h >> odp_packet_socket.h >> >> Mike >> >> >> Admit that _internal is not optimal post-fix, but it >> highlights that these files are _not_ API. Those are part of >> the implementation of an API. I think we must keep API and >> non-API files strictly separated. So that API file names are >> not reused anywhere else in the implementation. Some better >> pre or post fix could be used. >> >> -Petri >> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] <mailto:[email protected]> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> -- *Mike Holmes* >> Linaro Sr Technical Manager >> LNG - ODP >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] <mailto:[email protected]> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > -- *Mike Holmes* Linaro Sr Technical Manager LNG - ODP
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
