Default is 0. It includes all current and future flags. There's no point to define ODP_SHM_SW_AND_HW, that's defined when the flag value does not include ODP_SHM_SW_ONLY. This is how flag parameters work in general.
-Petri > -----Original Message----- > From: [email protected] [mailto:lng-odp- > [email protected]] On Behalf Of ext Mike Holmes > Sent: Wednesday, October 22, 2014 10:50 PM > To: [email protected] > Subject: [lng-odp] [PATCH] odp_shared_memory.h: Document default value > > Signed-off-by: Mike Holmes <[email protected]> > --- > Although adding the default description to the list of legal #defined > values > helps the reader understand what the default means, it looks like this > could be more clearly coded as an enum. > > platform/linux-generic/include/api/odp_shared_memory.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/platform/linux-generic/include/api/odp_shared_memory.h > b/platform/linux-generic/include/api/odp_shared_memory.h > index d8d40dd..d2965af 100644 > --- a/platform/linux-generic/include/api/odp_shared_memory.h > +++ b/platform/linux-generic/include/api/odp_shared_memory.h > @@ -34,6 +34,7 @@ extern "C" { > */ > > /* Share level */ > +#define ODP_SHM_SW_AND_HW 0x0 /**< Both SW and HW acess */ > #define ODP_SHM_SW_ONLY 0x1 /**< Application SW only, no HW access */ > #define ODP_SHM_PROC 0x2 /**< Share with external processes */ > > @@ -64,7 +65,7 @@ typedef struct odp_shm_info_t { > * @param name Name of the block (maximum ODP_SHM_NAME_LEN - 1 chars) > * @param size Block size in bytes > * @param align Block alignment in bytes > - * @param flags Shared mem parameter flags (ODP_SHM_*). Default value is > 0. > + * @param flags Shared mem parameter flags (ODP_SHM_*). Default value is > ODP_SHM_SW_AND_HW > * > * @return Pointer to the reserved block, or NULL > */ > -- > 1.9.1 > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
