As an aside, thanks Mike for the pointer to ODP_UNUSED. I just ran into that exact issue for the various unmap() calls that are no-ops in linux-generic.
Bill On Mon, Nov 10, 2014 at 10:44 AM, Alexandru Badicioiu < [email protected]> wrote: > It seems I resent the wrong patch. > > On 10 November 2014 18:33, Mike Holmes <[email protected]> wrote: > >> >> >> On 10 November 2014 10:30, <[email protected]> wrote: >> >>> From: Alexandru Badicioiu <[email protected]> >>> >>> This patch is required by crypto unit testing. >>> >>> Signed-off-by: Alexandru Badicioiu <[email protected]> >>> --- >>> platform/linux-generic/odp_crypto.c | 26 ++++++++++++++++++++++++++ >>> 1 files changed, 26 insertions(+), 0 deletions(-) >>> >>> diff --git a/platform/linux-generic/odp_crypto.c >>> b/platform/linux-generic/odp_crypto.c >>> index 1475437..b9dd3e7 100644 >>> --- a/platform/linux-generic/odp_crypto.c >>> +++ b/platform/linux-generic/odp_crypto.c >>> @@ -13,6 +13,7 @@ >>> #include <odp_align.h> >>> #include <odp_shared_memory.h> >>> #include <odp_crypto_internal.h> >>> +#include <odp_debug_internal.h> >>> #include <odp_hints.h> >>> #include <odph_packet.h> >>> >>> @@ -467,3 +468,28 @@ >>> odp_crypto_get_ses_create_compl_session(odp_buffer_t completion_event, >>> result = odp_buffer_addr(completion_event); >>> *session = result->session; >>> } >>> + >>> +void >>> +odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event, >>> + void *ctx) >>> +{ >>> >> >> use ODP_UNUSED for unused arguments not the void below >> >> >>> + (void)completion_event; >>> + (void)ctx; >>> + ODP_UNIMPLEMENTED(); >>> +} >>> + >>> +void >>> +*odp_crypto_get_operation_compl_ctx(odp_buffer_t completion_event) >>> +{ >>> >> >> use ODP_UNUSED for unused arguments not the void below >> >> >>> + (void)completion_event; >>> + ODP_UNIMPLEMENTED(); >>> + return NULL; >>> >> >> The documentation makes no mention of NULL being a possible error case, >> it just says "Returns user data" The documentation should be improved >> with this patch submission to indicate the error case NULL with a new >> @retval >> >> >>> +} >>> + >>> +odp_packet_t >>> +odp_crypto_get_operation_compl_packet(odp_buffer_t completion_event) >>> +{ >>> >> >> use ODP_UNUSED for unused arguments not the void below >> >> >>> + (void)completion_event; >>> + ODP_UNIMPLEMENTED(); >>> + return ODP_PACKET_INVALID; >>> >> >> The documentation makes no mention of ODP_PACKET_INVALID being a >> possible error case, it just says "Returns Packet structure where data now >> resides" The documentation should be improved with this patch submission to >> indicate the error case ODP_PACKET_INVALID with a new @retval >> >> >>> +} >>> -- >>> 1.7.3.4 >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> [email protected] >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> >> -- >> *Mike Holmes* >> Linaro Sr Technical Manager >> LNG - ODP >> > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > >
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
