I think it is redundant, we know it is a test because it is in the test directory and so it conveys no value to add "test" to the name
On 10 November 2014 17:07, Maxim Uvarov <[email protected]> wrote: > On 11/11/2014 12:07 AM, Anders Roxell wrote: > >> Synchronise the file name with the test suite name. >> > > why is that needed? > > Maxim. > > > Signed-off-by: Anders Roxell <[email protected]> >> --- >> test/cunit/Makefile.am | 2 +- >> test/cunit/{odp_init_test.c => odp_init.c} | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> rename test/cunit/{odp_init_test.c => odp_init.c} (94%) >> >> diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am >> index 927a5a5..4014bed 100644 >> --- a/test/cunit/Makefile.am >> +++ b/test/cunit/Makefile.am >> @@ -10,4 +10,4 @@ bin_PROGRAMS = odp_init >> odp_init_LDFLAGS = $(AM_LDFLAGS) -static -lcunit >> endif >> -dist_odp_init_SOURCES = odp_init_test.c >> +dist_odp_init_SOURCES = odp_init.c >> diff --git a/test/cunit/odp_init_test.c b/test/cunit/odp_init.c >> similarity index 94% >> rename from test/cunit/odp_init_test.c >> rename to test/cunit/odp_init.c >> index a612109..88e6235 100644 >> --- a/test/cunit/odp_init_test.c >> +++ b/test/cunit/odp_init.c >> @@ -38,7 +38,7 @@ int main(void) >> if (CUE_SUCCESS != CU_initialize_registry()) >> return CU_get_error(); >> /* add a suite to the registry */ >> - ptr_suite = CU_add_suite("odp intalization", init, finalise); >> + ptr_suite = CU_add_suite(__FILE__, init, finalise); >> if (NULL == ptr_suite) { >> CU_cleanup_registry(); >> return CU_get_error(); >> > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > -- *Mike Holmes* Linaro Sr Technical Manager LNG - ODP
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
