OK, will make these changes in v3. The line fill is done automagically by Emacs. I just need to change the default wrap column from 66 to 80 if that works better for you.
Bill On Fri, Nov 14, 2014 at 11:42 AM, Anders Roxell <[email protected]> wrote: > On 2014-11-13 20:18, Bill Fischofer wrote: > > Signed-off-by: Bill Fischofer <[email protected]> > > --- > > platform/linux-generic/Makefile.am | 1 + > > platform/linux-generic/include/api/odp_buffer.h | 9 +-- > > .../linux-generic/include/api/odp_buffer_pool.h | 5 +- > > .../linux-generic/include/api/odp_impl_types.h | 72 > ++++++++++++++++++++++ > > Instead of of odp_impl_types.h change it to odp_platform_types.h > > I think it's more clear what we mean. > > > platform/linux-generic/include/api/odp_packet.h | 30 --------- > > platform/linux-generic/include/api/odp_packet_io.h | 12 +--- > > 6 files changed, 76 insertions(+), 53 deletions(-) > > create mode 100644 platform/linux-generic/include/api/odp_impl_types.h > > > > diff --git a/platform/linux-generic/Makefile.am > b/platform/linux-generic/Makefile.am > > index 0153a22..66ba7fb 100644 > > --- a/platform/linux-generic/Makefile.am > > +++ b/platform/linux-generic/Makefile.am > > @@ -36,6 +36,7 @@ include_HEADERS = \ > > > $(top_srcdir)/platform/linux-generic/include/api/odp_ticketlock.h \ > > > $(top_srcdir)/platform/linux-generic/include/api/odp_time.h \ > > > $(top_srcdir)/platform/linux-generic/include/api/odp_timer.h \ > > + > $(top_srcdir)/platform/linux-generic/include/api/odp_impl_types.h \ > > > $(top_srcdir)/platform/linux-generic/include/api/odp_version.h > > > > subdirheadersdir = $(includedir) > > diff --git a/platform/linux-generic/include/api/odp_buffer.h > b/platform/linux-generic/include/api/odp_buffer.h > > index 289e0eb..141a16b 100644 > > --- a/platform/linux-generic/include/api/odp_buffer.h > > +++ b/platform/linux-generic/include/api/odp_buffer.h > > @@ -20,20 +20,13 @@ extern "C" { > > > > > > #include <odp_std_types.h> > > - > > +#include <odp_impl_types.h> > > > > /** @defgroup odp_buffer ODP BUFFER > > * Operations on a buffer. > > * @{ > > */ > > > > -/** > > - * ODP buffer > > - */ > > -typedef uint32_t odp_buffer_t; > > - > > -#define ODP_BUFFER_INVALID (0xffffffff) /**< Invalid buffer */ > > - > > > > /** > > * Buffer start address > > diff --git a/platform/linux-generic/include/api/odp_buffer_pool.h > b/platform/linux-generic/include/api/odp_buffer_pool.h > > index d04abf0..c46044d 100644 > > --- a/platform/linux-generic/include/api/odp_buffer_pool.h > > +++ b/platform/linux-generic/include/api/odp_buffer_pool.h > > @@ -21,6 +21,7 @@ extern "C" { > > > > > > #include <odp_std_types.h> > > +#include <odp_impl_types.h> > > #include <odp_buffer.h> > > > > /** @addtogroup odp_buffer > > @@ -34,10 +35,6 @@ extern "C" { > > /** Invalid buffer pool */ > > #define ODP_BUFFER_POOL_INVALID 0 > > > > -/** ODP buffer pool */ > > -typedef uint32_t odp_buffer_pool_t; > > - > > - > > /** > > * Create a buffer pool > > * > > diff --git a/platform/linux-generic/include/api/odp_impl_types.h > b/platform/linux-generic/include/api/odp_impl_types.h > > new file mode 100644 > > index 0000000..f4deedb > > --- /dev/null > > +++ b/platform/linux-generic/include/api/odp_impl_types.h > > @@ -0,0 +1,72 @@ > > +/* Copyright (c) 2014, Linaro Limited > > + * All rights reserved. > > + * > > + * SPDX-License-Identifier: BSD-3-Clause > > + */ > > + > > + > > +/** > > + * @file > > + * ODP implementation types > > + * This file contains all of the implementation-defined types for ODP > > + * abstract definitions. Having this in one file means that other ODP > > + * API files are implementation-independent and avoids circular > > + * dependencies for files that refer to types managed by other > > + * components. Included here are typedefs and related typed constants > > + * that are referenced by other ODP API files. > > Again, why are you only using 70 characters per row and not 80? > > > + */ > > + > > +#ifndef ODP_IMPL_TYPES_H_ > > +#define ODP_IMPL_TYPES_H_ > > + > > +/** @defgroup odp_types ODP TYPES > > ODP PLATFORM TYPES > > > + * Implementation definitions for ODP abstract types. > > Implementation specific definitions of ODP abstract types. > > > Cheers, > Anders >
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
