On 11/17/2014 12:01 PM, Taras Kondratiuk wrote:
On 11/15/2014 12:01 PM, Maxim Uvarov wrote:
Merged!

Guys, what about commit message? How one should understand what was the
reason for this patch by looking into git log?


yes, agree maybe we need some more clear message for that. But I think short description says what was done.

Also it would be nice to have 'linux-generic:' prefix in the subject.
So browsing via git log one could easily determine what was touched by the patch.


No prefix by default means it's for linux-generic.

Maxim.

Bill, for a one patch series a cover letter is usually redundant.
Normally text from you cover letter should be here in the commit
message. If there are something you want to mention, but don't want it
to go into the git history, then put that after '---' delimiter a few
lines below (just below the Signed-off-by tag).


Thanks,
Maxim.

On 11/14/2014 09:40 PM, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer <[email protected]>
---
  platform/linux-generic/Makefile.am                 |  1 +
  platform/linux-generic/include/api/odp_buffer.h    |  9 +--
  .../linux-generic/include/api/odp_buffer_pool.h    |  5 +-
  platform/linux-generic/include/api/odp_packet.h    | 30 ---------
  platform/linux-generic/include/api/odp_packet_io.h | 12 +---
  .../linux-generic/include/api/odp_platform_types.h | 71
++++++++++++++++++++++
  6 files changed, 75 insertions(+), 53 deletions(-)
  create mode 100644


_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to