On 11/19/2014 07:28 PM, Mike Holmes wrote:
Can you work the weak linkage replacement for ODP_ASSERT into this
patch so that the application can redirect calls to abort.
I posed an ODP_WEAK patch yesterday.
__weak__ is symbol attribute (function, variable) not macros. Do you
want to make ODP_ASSERT function?
Maxim.
The unit tests need to be able to redirect the abort right now so this
would be very valuable immediately.
On 19 November 2014 11:12, Maxim Uvarov <[email protected]
<mailto:[email protected]>> wrote:
Fix macro logic. Application has to be terminated in any case.
Signed-off-by: Maxim Uvarov <[email protected]
<mailto:[email protected]>>
---
platform/linux-generic/include/api/odp_debug.h | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/platform/linux-generic/include/api/odp_debug.h
b/platform/linux-generic/include/api/odp_debug.h
index c9b2edd..1cbcb61 100644
--- a/platform/linux-generic/include/api/odp_debug.h
+++ b/platform/linux-generic/include/api/odp_debug.h
@@ -57,10 +57,13 @@ extern "C" {
/**
* Runtime assertion-macro - aborts if 'cond' is false.
*/
-#define ODP_ASSERT(cond, msg) \
- do { if ((ODP_DEBUG == 1) && (!(cond))) { \
- ODP_ERR("%s\n", msg); \
- abort(); } \
+#define ODP_ASSERT(cond, msg) \
+ do { \
+ if (!(cond)) { \
+ if (ODP_DEBUG == 1) \
+ ODP_ERR("%s\n", msg); \
+ abort(); \
+ } \
} while (0)
/**
--
1.8.5.1.163.gd7aced9
_______________________________________________
lng-odp mailing list
[email protected] <mailto:[email protected]>
http://lists.linaro.org/mailman/listinfo/lng-odp
--
*Mike Holmes*
Linaro Sr Technical Manager
LNG - ODP
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
