Maxim, I think this might be from your patches
Mike
---------- Forwarded message ----------
From: <[email protected]>
Date: 23 November 2014 14:11
Subject: New Defects reported by Coverity Scan for ODP
To: [email protected]
Hi,
Please find the latest report on new defect(s) introduced to ODP found with
Coverity Scan.
4 new defect(s) introduced to ODP found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 83058: Buffer not null terminated (BUFFER_SIZE_WARNING)
/platform/linux-generic/odp_packet_io.c: 207 in odp_pktio_open()
** CID 83059: Dereference null return value (NULL_RETURNS)
/platform/linux-generic/odp_packet_io.c: 171 in odp_pktio_open()
/platform/linux-generic/odp_packet_io.c: 182 in odp_pktio_open()
/platform/linux-generic/odp_packet_io.c: 192 in odp_pktio_open()
** CID 83060: Buffer not null terminated (BUFFER_SIZE_WARNING)
/platform/linux-generic/odp_packet_io.c: 505 in odp_pktio_set_mtu()
** CID 83061: Buffer not null terminated (BUFFER_SIZE_WARNING)
/platform/linux-generic/odp_packet_io.c: 535 in odp_pktio_mtu()
________________________________________________________________________________________________________
*** CID 83058: Buffer not null terminated (BUFFER_SIZE_WARNING)
/platform/linux-generic/odp_packet_io.c: 207 in odp_pktio_open()
201 unlock_entry(pktio_entry);
202 free_pktio_entry(id);
203 ODP_ERR("Unable to init any I/O type.\n");
204 return ODP_PKTIO_INVALID;
205
206 done:
>>> CID 83058: Buffer not null terminated (BUFFER_SIZE_WARNING)
>>> Calling strncpy with a maximum size argument of 16 bytes on
destination array "pktio_entry->s.name" of size 16 bytes might leave the
destination string unterminated.
207 strncpy(pktio_entry->s.name, dev, IFNAMSIZ);
208 unlock_entry(pktio_entry);
209 return id;
210 }
211
212 int odp_pktio_close(odp_pktio_t id)
________________________________________________________________________________________________________
*** CID 83059: Dereference null return value (NULL_RETURNS)
/platform/linux-generic/odp_packet_io.c: 171 in odp_pktio_open()
165 /* if successful, alloc_pktio_entry() returns with the
entry locked */
166
167 pktio_entry = get_entry(id);
168
169 ODP_DBG("ODP_PKTIO_USE_FANOUT: %d\n", fanout);
170 if (getenv("ODP_PKTIO_DISABLE_SOCKET_MMAP") == NULL) {
>>> CID 83059: Dereference null return value (NULL_RETURNS)
>>> Dereferencing a null pointer "pktio_entry".
171 pktio_entry->s.type = ODP_PKTIO_TYPE_SOCKET_MMAP;
172 res =
setup_pkt_sock_mmap(&pktio_entry->s.pkt_sock_mmap, dev,
173 pool, fanout);
174 if (res != -1) {
175 ODP_DBG("IO type:
ODP_PKTIO_TYPE_SOCKET_MMAP\n");
176 goto done;
/platform/linux-generic/odp_packet_io.c: 182 in odp_pktio_open()
176 goto done;
177 }
178 close_pkt_sock_mmap(&pktio_entry->s.pkt_sock_mmap);
179 }
180
181 if (getenv("ODP_PKTIO_DISABLE_SOCKET_MMSG") == NULL) {
>>> CID 83059: Dereference null return value (NULL_RETURNS)
>>> Dereferencing a null pointer "pktio_entry".
182 pktio_entry->s.type = ODP_PKTIO_TYPE_SOCKET_MMSG;
183 res = setup_pkt_sock(&pktio_entry->s.pkt_sock, dev,
pool);
184 if (res != -1) {
185 ODP_DBG("IO type:
ODP_PKTIO_TYPE_SOCKET_MMSG\n");
186 goto done;
187 }
/platform/linux-generic/odp_packet_io.c: 192 in odp_pktio_open()
186 goto done;
187 }
188 close_pkt_sock(&pktio_entry->s.pkt_sock);
189 }
190
191 if (getenv("ODP_PKTIO_DISABLE_SOCKET_BASIC") == NULL) {
>>> CID 83059: Dereference null return value (NULL_RETURNS)
>>> Dereferencing a null pointer "pktio_entry".
192 pktio_entry->s.type = ODP_PKTIO_TYPE_SOCKET_BASIC;
193 res = setup_pkt_sock(&pktio_entry->s.pkt_sock, dev,
pool);
194 if (res != -1) {
195 ODP_DBG("IO type:
ODP_PKTIO_TYPE_SOCKET_BASIC\n");
196 goto done;
197 }
________________________________________________________________________________________________________
*** CID 83060: Buffer not null terminated (BUFFER_SIZE_WARNING)
/platform/linux-generic/odp_packet_io.c: 505 in odp_pktio_set_mtu()
499
500 if (entry->s.pkt_sock_mmap.sockfd)
501 sockfd = entry->s.pkt_sock_mmap.sockfd;
502 else
503 sockfd = entry->s.pkt_sock.sockfd;
504
>>> CID 83060: Buffer not null terminated (BUFFER_SIZE_WARNING)
>>> Calling strncpy with a maximum size argument of 16 bytes on
destination array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the
destination string unterminated.
505 strncpy(ifr.ifr_name, entry->s.name, IFNAMSIZ);
506 ifr.ifr_mtu = mtu;
507
508 ret = ioctl(sockfd, SIOCSIFMTU, (caddr_t)&ifr);
509 if (ret < 0) {
510 ODP_DBG("ioctl SIOCSIFMTU error\n");
________________________________________________________________________________________________________
*** CID 83061: Buffer not null terminated (BUFFER_SIZE_WARNING)
/platform/linux-generic/odp_packet_io.c: 535 in odp_pktio_mtu()
529
530 if (entry->s.pkt_sock_mmap.sockfd)
531 sockfd = entry->s.pkt_sock_mmap.sockfd;
532 else
533 sockfd = entry->s.pkt_sock.sockfd;
534
>>> CID 83061: Buffer not null terminated (BUFFER_SIZE_WARNING)
>>> Calling strncpy with a maximum size argument of 16 bytes on
destination array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the
destination string unterminated.
535 strncpy(ifr.ifr_name, entry->s.name, IFNAMSIZ);
536
537 ret = ioctl(sockfd, SIOCGIFMTU, &ifr);
538 if (ret < 0) {
539 ODP_DBG("ioctl SIOCGIFMTU error\n");
540 return -1;
541 }
542
543 return ifr.ifr_mtu;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
http://scan.coverity.com/projects/2925?tab=overview
To unsubscribe from the email notification for new defects,
http://scan5.coverity.com/cgi-bin/unsubscribe.py
--
*Mike Holmes*
Linaro Sr Technical Manager
LNG - ODP
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
