On 11/25/2014 03:34 PM, Mike Holmes wrote:
On 25 November 2014 at 07:11, Taras Kondratiuk <[email protected] <mailto:[email protected]>> wrote: diff --git a/test/validation/odp_init.c b/test/validation/odp_init.c index 88e6235..aa7439d 100644 --- a/test/validation/odp_init.c +++ b/test/validation/odp_init.c @@ -20,9 +20,10 @@ static void test_odp_init_global(void) CU_ASSERT(status == 0); } -static int init(void) +static int init_suite(void) { - printf("\tODP version: %s\n", odp_version_api_str()); + printf("\tODP API version: %s\n", odp_version_api_str()); + printf("\tODP implementation version: %s\n", odp_version_impl_str()); Suite init function should perform necessary actions to prepare system for a suit execution. Printing ODP info has nothing to do with this. Also this information is the same for all test suites, so normally it should be printed directly from main(). When we merge this into a library to facilitate the arbitrary execution of suites main will not necessarily be called. A suite might be called from one of the interactive CUnit shells or GUI and main will not be present except for the batch processing case.
I'm not sure I get your point. main() will be called in any way. Actually my comment is relevant especially for the interactive mode. I'd expect to see this info printed on a start of interactive mode (before any test started), but not on each invocation of a testsuite. _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
