I think this check is too strict and should be removed. I remember we had a discussion about this many months ago and already then I was of the opinion that this check is unnecessary and not very beneficial.
The 64-byte limit originates from Ethernet *link* restrictions and doesn't have anything to do with parsing packets. We want to be able to use virtual interfaces even in production systems, they are actually some very good reasons for that. -- Ola On 26 November 2014 at 09:41, Shmulik Ladkani <[email protected]> wrote: > On Tue, 25 Nov 2014 15:04:53 -0600 Bill Fischofer <[email protected]> > wrote: >> These functions are scheduled for rework as part of the packet API >> revisions. Will be sure to address this point as part of that rework. > > Thanks. > > If there's a concensus the 'len < ODPH_ETH_LEN_MIN' is too strict, any > reason not to submit a tiny patch that removes this sanity test? > > This could be beneficial, as your patchset would therefore not > carry this logical change, but instead focus on packet API changes. > > Regards, > Shmulik > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
