I want my gcc to catch such things also. Are you using gcc?
mine is: gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-2ubuntu1~12.04) Maxim. On 12/01/2014 06:14 PM, Anders Roxell wrote:
On 2014-12-01 17:08, Maxim Uvarov wrote:v3: - socket() 0 is valid descr, so init it to -1. - use ssize_t type to return readable return codes. - use standard errno codes for failures; v2: In that version I tried to account all comments together. Boolean, loop, API changes and etc. Maxim Uvarov (10): linux-generic: set not initialized socket to -1 API: promisc mode manipulation functions API: pktio: mac addr functions cunit: pktio: mtu and promisc mode cunit: add mac test API: odp_pktio_open loop back interface linux-generic: odp_pktio_open loop support cunit: use special device for testing linux-generic: correct socket get for mtu functions API and linux-generic: pktio update return codes platform/linux-generic/include/api/odp_packet_io.h | 57 +++++- platform/linux-generic/include/api/odp_std_types.h | 2 + platform/linux-generic/odp_packet_io.c | 219 ++++++++++++++++++++- test/validation/Makefile.am | 4 +- test/validation/odp_pktio.c | 217 ++++++++++++++++++++ 5 files changed, 491 insertions(+), 8 deletions(-) create mode 100644 test/validation/odp_pktio.c$ cat summary.log Using patch dir: /home/anders/incoming/maxim-pktio-v3 Using patch: /home/anders/incoming/maxim-pktio-v3/lng-odp_PATCHv3_01-10_linux-generic_set_not_initialized_socket_ git am /home/anders/incoming/maxim-pktio-v3/lng-odp_PATCHv3_01-10_linux-generic_set_not_initialized_socket_ Patch applied, building... PASS: odp_init PASS: odp_queue PASS: odp_crypto PASS: odp_shm ============================================================================ Testsuite summary for OpenDataPlane 0.3.0 ============================================================================ # TOTAL: 4 # PASS: 4 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ Using patch: /home/anders/incoming/maxim-pktio-v3/lng-odp_PATCHv3_02-10_API_promisc_mode_manipulation_functions.mbox git am /home/anders/incoming/maxim-pktio-v3/lng-odp_PATCHv3_02-10_API_promisc_mode_manipulation_functions.mbox Patch applied, building... BUILD ERROR! Making all in platform make[1]: Entering directory '/home/anders/src/check-odp/odp/platform' Making all in linux-generic make[2]: Entering directory '/home/anders/src/check-odp/odp/platform/linux-generic' CC odp_barrier.lo CC odp_buffer.lo CC odp_buffer_pool.lo CC odp_classification.lo CC odp_coremask.lo CC odp_crypto.lo CC odp_init.lo CC odp_impl.lo CC odp_linux.lo CC odp_packet.lo CC odp_packet_flags.lo CC odp_packet_io.lo odp_packet_io.c: In function 'odp_pktio_promisc_set': odp_packet_io.c:570:14: error: array subscript is above array bounds [-Werror=array-bounds] ifr.ifr_name[IFNAMSIZ] = 0; ^ odp_packet_io.c: In function 'odp_pktio_promisc_enabled': odp_packet_io.c:611:14: error: array subscript is above array bounds [-Werror=array-bounds] ifr.ifr_name[IFNAMSIZ] = 0; ^ cc1: all warnings being treated as errors Makefile:559: recipe for target 'odp_packet_io.lo' failed make[2]: *** [odp_packet_io.lo] Error 1 make[2]: Leaving directory '/home/anders/src/check-odp/odp/platform/linux-generic' Makefile:369: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/home/anders/src/check-odp/odp/platform' Makefile:454: recipe for target 'all-recursive' failed make: *** [all-recursive] Error 1
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
