When I run the version of checkpatch that's part of odp.git I get this: bill@Ubuntu13:~/linaro/v10bufpool$ ./scripts/checkpatch.pl *.patch total: 0 errors, 0 warnings, 0 checks, 2392 lines checked
NOTE: Ignored message types: DEPRECATED_VARIABLE NEW_TYPEDEFS 0001-ODP-buffer-pool-restructure-for-v1.0-APIs.patch has no obvious style problems and is ready for submission. bill@Ubuntu13:~/linaro/v10bufpool$ What version of checkpatch are you running? The two other routines mentioned represent approximately 30 lines of a 1000+ line patch. If there's consensus that combining them is a barrier to timely review of this patch I can split things up, but this seems like busy work to me as we're not trying to support cherry-picking bits and pieces of the approved APIs. Bill On Mon, Dec 1, 2014 at 4:27 PM, Anders Roxell <[email protected]> wrote: > Drop "for v1.0 APIs" > > You introduced some warnings that we didn't have: > odp_config.h:55: warning: Member ODP_CONFIG_BUF_MAX_SIZE (macro > definition) of group odp_compiler_optim is not documented. > odp_config.h:55: warning: Member ODP_CONFIG_BUF_MAX_SIZE (macro > definition) of group odp_compiler_optim is not documented. > odp_buffer_pool.h:127: warning: Member name (variable) of class > odp_buffer_pool_info_t is not documented. > odp_buffer_pool.h:128: warning: Member params (variable) of class > odp_buffer_pool_info_t is not documented. > odp_buffer_pool.h:55: warning: Member buf_size (variable) of class > odp_buffer_pool_param_t is not documented. > odp_buffer_pool.h:56: warning: Member buf_align (variable) of class > odp_buffer_pool_param_t is not documented. > odp_buffer_pool.h:57: warning: Member num_bufs (variable) of class > odp_buffer_pool_param_t is not documented. > odp_buffer_pool.h:58: warning: Member buf_type (variable) of class > odp_buffer_pool_param_t is not documented. > > > On 2014-11-30 19:47, Bill Fischofer wrote: > > ODP buffer pool restricture to enable support for v1.0 APIs. > > Remove, doesn't add any value. > > > Implements the following revised/new APIs: > > > > odp_buffer_pool_create() > > odp_buffer_pool_destroy() > > odp_buffer_pool_info() > > We said it during last weeks call, one patch per API. > > Please split this into three patches. > > Cheers, > Anders >
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
