On 5 December 2014 at 10:04, Taras Kondratiuk <[email protected]> wrote: > On 12/04/2014 10:25 PM, Mike Holmes wrote: >> >> @@ -138,12 +114,6 @@ extern "C" { >> #define ODP_ALIGN_ROUNDDOWN_PTR_POWER_2(x, align)\ >> ((void *)ODP_ALIGN_ROUNDDOWN_POWER_2((uintptr_t)(x), >> (uintptr_t)(align))) > > > Only part of internal macros were moved. For example why > ODP_ALIGN_ROUNDDOWN_PTR_POWER_2() is still in public header? > What was the criteria to choose which function to move?
I haven't had a look at what remains public after the patch but ODP applications have a legitimate interest in making their data structures cache line (and even page) aligned etc. So I would expect the following macros (or some subset) to remain public: ODP_ALIGNED ODP_ALIGNED_CACHE ODP_ALIGNED_PAGE ODP_PACKED ODP_CACHE_LINE_SIZE ODP_ALIGN_ROUNDUP or ODP_CACHE_LINE_SIZE_ROUNDUP (why so long names?) ODP_PAGE_SIZE_ROUNDUP I also recommend that we use the shorter term "LINE" instead of "CACHE_LINE". PAGE and LINE, short and nice. > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
