On 10 December 2014 at 09:13, Anders Roxell <[email protected]> wrote: > On 2014-12-09 17:56, Mike Holmes wrote: >> Has checkpatch issues >> >> Using patch: >> /home/mike/incoming/lng-odp_PATCH_3-3_test_odp_timer.h_cunit_test.mbox >> git am >> /home/mike/incoming/lng-odp_PATCH_3-3_test_odp_timer.h_cunit_test.mbox >> Patch applied, building... >> WARNING: line over 80 characters >> #238: FILE: test/validation/odp_timer.c:185: >> + CU_FAIL("Failed to set timer (tooearly/toolate)"); >> >> total: 0 errors, 1 warnings, 0 checks, 359 lines checked >> >> NOTE: Ignored message types: DEPRECATED_VARIABLE NEW_TYPEDEFS >> >> 0001-test-odp_timer.h-cunit-test.patch has style problems, please review. > > Do we want to split up this printout? No.
> If you're not familiar with the code and you run the validation tests > and got this failure printed out. I would grep for that failure message > (the string) in the code too see how I got there. Exactly. > And if we split this string up into multiple rows just to make > check-patch happy it will make it harder to search after the failure > message then right? Correct. And I even think checkpatch for this reason will complain if you split the string. -- Ola > > Cheers, > Anders _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
