On 16 December 2014 at 16:33, Bill Fischofer <[email protected]> wrote: > The reason for the include hierarchy used is to break up circular > dependencies that might otherwise arise. If someone comes up with a cleaner > way of doing this, a patch to do this would certainly be appropriate. I added these includes to odp_buffer_inlines.h: #include <odp_buffer_internal.h> #include <odp_buffer_pool_internal.h>
Does this create the potential for a circular dependency? > > On Tue, Dec 16, 2014 at 9:26 AM, Taras Kondratiuk > <[email protected]> wrote: >> >> On 12/16/2014 05:22 PM, Ola Liljedahl wrote: >>> >>> This internal header files does not include header files which it >>> depends on (e.g. odp_buffer_internal.h, odp_buffer_pool_internal.h) >>> and thus becomes dependent on the parent file to include the necessary >>> files. I think this is poor design, all header files should be >>> self-sufficient. >> >> >> Post a fix :) >> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
